HomePhabricator

In ApplicationTransactionEditor, determine new objects with "getID()" instead…

Authored by epriestley on Apr 29 2019, 2:33 PM.

Description

In ApplicationTransactionEditor, determine new objects with "getID()" instead of "getPHID()"

Summary:
See https://discourse.phabricator-community.org/t/unable-to-reload-object-that-hasnt-been-loaded/2677.

When editing "Config" objects, they currently get a PHID set outside of the TransactionEditor. They probably should not, but fixing that is likely an involved change.

This causes us to incorrectly fail to detect $is_new correctly and try to reload() and object with no ID.

To work around this, test for new objects with getID() instead of getPHID().

Test Plan: Edited any config value with the web UI.

Reviewers: amckinley

Differential Revision: https://secure.phabricator.com/D20482

Details

Committed
epriestleyApr 29 2019, 2:37 PM
Pushed
epriestleyApr 29 2019, 2:37 PM
Parents
rPc0a4d1de13a8: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22731
Build 31163: Run Core Tests