Differential D20485

Add a rough "Chart" Dashboard Panel
ClosedPublic
Actions

Authored by epriestley on Apr 30 2019, 3:36 PM.

Tags

None

Subscribers

Details

Reviewers

Maniphest Tasks

T13279: Build Charting for Facts

Commits

rPff6b13872ccf: Add a rough "Chart" Dashboard Panel

Summary

Depends on D20484. Ref T13279. Allows a chart to render as a panel.

Configuring these is currently quite low-level (you have to manually copy/paste a chart key in), but works well enough.

Test Plan

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 30 2019, 3:36 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptApr 30 2019, 3:36 PM

Harbormaster completed remote builds in B22740: Diff 48867.Apr 30 2019, 3:38 PM

epriestley requested review of this revision.Apr 30 2019, 3:38 PM

epriestley added a child revision: D20486: Replace the chart in Maniphest Reports with a chart driven by Facts.Apr 30 2019, 3:42 PM

amckinley accepted this revision.May 21 2019, 8:36 PM

This revision is now accepted and ready to land.May 21 2019, 8:36 PM

Closed by commit rPff6b13872ccf: Add a rough "Chart" Dashboard Panel (authored by epriestley). · Explain WhyMay 22 2019, 11:36 AM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPff6b13872ccf: Add a rough "Chart" Dashboard Panel.

epriestley mentioned this in rPff6b13872ccf: Add a rough "Chart" Dashboard Panel.

Revision Contents
Changeset List

			Path	Packages
M			src/__phutil_library_map__.php (4 lines)
A	M		src/applications/dashboard/paneltype/PhabricatorDashboardChartPanelType.php (76 lines)
A	M		src/applications/dashboard/xaction/panel/PhabricatorDashboardChartPanelChartTransaction.php (12 lines)
M			src/applications/fact/controller/PhabricatorFactChartController.php (11 lines)
M			src/applications/fact/engine/PhabricatorChartEngine.php (18 lines)

Diff 48991

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/paneltype/PhabricatorDashboardChartPanelType.php

Loading...

src/applications/dashboard/xaction/panel/PhabricatorDashboardChartPanelChartTransaction.php

Loading...

src/applications/fact/controller/PhabricatorFactChartController.php

Loading...

src/applications/fact/engine/PhabricatorChartEngine.php

Loading...