Page MenuHomePhabricator

Render charts from storage instead of just one ad-hoc hard-coded chart
ClosedPublic

Authored by epriestley on Apr 30 2019, 3:31 PM.
Tags
None
Referenced Files
F15420509: D20483.id48990.diff
Fri, Mar 21, 2:31 PM
F15420148: D20483.id48865.diff
Fri, Mar 21, 11:45 AM
F15416656: D20483.diff
Thu, Mar 20, 12:49 PM
F15412964: D20483.id.diff
Wed, Mar 19, 4:02 PM
F15412291: D20483.id48865.diff
Wed, Mar 19, 12:16 PM
F15409791: D20483.id.diff
Wed, Mar 19, 5:18 AM
Unknown Object (File)
Mon, Mar 3, 9:05 AM
Unknown Object (File)
Mon, Mar 3, 6:37 AM
Subscribers

Details

Summary

Ref T13279. This changes the chart controller:

  • if we have no arguments, build a demo chart and redirect to it;
  • otherwise, load the specified chart from storage and render it.

This mostly prepares for "Chart" panels on dashboards.

Test Plan

Visited /fact/chart/, got redirected to a chart from storage.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable