Page MenuHomePhabricator

Render charts from storage instead of just one ad-hoc hard-coded chart
ClosedPublic

Authored by epriestley on Apr 30 2019, 3:31 PM.

Details

Summary

Ref T13279. This changes the chart controller:

  • if we have no arguments, build a demo chart and redirect to it;
  • otherwise, load the specified chart from storage and render it.

This mostly prepares for "Chart" panels on dashboards.

Test Plan

Visited /fact/chart/, got redirected to a chart from storage.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.