Page MenuHomePhabricator

Render charts from storage instead of just one ad-hoc hard-coded chart
ClosedPublic

Authored by epriestley on Apr 30 2019, 3:31 PM.
Tags
None
Referenced Files
F19934463: D20483.diff
Sat, Apr 11, 3:56 PM
F19931907: D20483.id48990.diff
Fri, Apr 10, 5:39 AM
F19931502: D20483.id48990.diff
Fri, Apr 10, 12:26 AM
F19926159: D20483.id48990.diff
Tue, Apr 7, 3:30 PM
F19900763: D20483.diff
Mon, Mar 30, 5:57 AM
F19874484: D20483.id48865.diff
Mar 15 2026, 6:55 PM
F19800728: D20483.id.diff
Feb 28 2026, 5:41 PM
F19614444: D20483.id48865.diff
Feb 3 2026, 9:54 PM
Subscribers

Details

Summary

Ref T13279. This changes the chart controller:

  • if we have no arguments, build a demo chart and redirect to it;
  • otherwise, load the specified chart from storage and render it.

This mostly prepares for "Chart" panels on dashboards.

Test Plan

Visited /fact/chart/, got redirected to a chart from storage.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable