HomePhabricator

Fix an issue where editing a dashboard panel from a dashboard could duplicate…

Description

Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel

Summary:
Depends on D20472. Ref T13272. Currently, when you edit a panel from a dashboard, we try to add the panel to the dashboard. This always works since dashboards no longer enforce panel uniqueness, and you can end up with duplicate panels.

Instead, only add panels if we're creating them.

Test Plan:

  • Edited an existing panel, no duplication.
  • Created a new panel, saw it added to the dashboard.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13272

Differential Revision: https://secure.phabricator.com/D20473

Details

Provenance
epriestleyAuthored on Apr 25 2019, 5:35 PM
epriestleyPushed on Apr 30 2019, 3:27 PM
Reviewer
amckinley
Parents
rP5462a52b8a0c: Update Quickstart SQL
Branches
Unknown
Tags
Unknown
Tasks
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Build Status
Buildable 22737
Build 31170: Run Core Tests