so these will tasks will permanently

To those still interested, Spinnaker (OSS from Netflix + Google) is targeting the Deployment part of this flow (everything after a Release Candidate is created).
It only handled "cloud" deployments, and offers as much complexity as you can ever want, including "Wait for human approval", Canary deployments, blue-green, etc.

• Improve help text.

I think it's a little unfair to remove this and the similar warning [about running the daemons] back on line 22.

Please use the Discourse forum for this kind of discussion.

Gentle ping here again :) Has anyone managed to get a webhook triggered on a phabricator git repo, once-per-push, not once-per-each-commit ?

• Typechecking.

I think that's reasonable -- if there are at least, say, 11 consecutive lines affected only by the same indentation level change (or the line is blank), we could show the first 3, fold the middle 5+, then show the last 3.

!== 0 and !== mask have different meanings when mask has multiple bits set. Today, IMPORTED_CLOSEABLE has just one bit set, so both tests would do the same thing. But the adjacent IMPORTED_ALL mask has several, and using the more general form is safer if IMPORTED_CLOSEABLE ever has multiple bits, or this code gets copy/pasted elsewhere or something.

(This seems stable now, and there's no specific action here.)

• Typo fix.

One note here is that HeraldPreCommitContentAdapter has some similar logic, although it's more low-level.

The "how do we store this data" question kind of relates back to T13056. This is a case where we have edge-like data (Commit Has Related Revision) but we also have metadata (why the two are associated). This currently isn't stored as edge data, but a possibly cleaner approach would be:

The reproduction case for this may be "have a ref which is an annotated tag". Let me see if that works.

There's not much of a wire-proto.c to reference. Here's the code that generates the entire thing we're parsing (in Git 2.21-rc1):

PHI1159 would like build failures exposed to Herald to trigger audits. See also PHI953. See also PHI901.

In PHI1008, when commit X reverts commit Y, we don't write a revert edge between X and revisions associated with Y. We should.