Page MenuHomePhabricator
Feed Advanced Search

Dec 3 2020

epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

That seems reasonable. I also ran into a couple of other suggestions elsewhere:

Dec 3 2020, 4:32 PM · Workboards (v3)
20after4 added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

Off the wall suggestion: how about a trigger that sets the subtype:

Dec 3 2020, 7:31 AM · Workboards (v3)

Dec 19 2019

epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

See also PHI1594, which wants:

Dec 19 2019, 5:18 PM · Workboards (v3)

Jul 31 2019

epriestley closed T4900: Workboards updating in real time as Resolved.

See T13357 for followup.

Jul 31 2019, 8:13 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20689: Don't try to emit project board update events if there are no projects to update.
Jul 31 2019, 7:42 PM · Workboards (v3), User Delight, Wikimedia

Jul 24 2019

epriestley added a revision to T4900: Workboards updating in real time: D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.
Jul 24 2019, 6:11 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

There's currently a bug (likely related to D20652 or D20654?) where normal edits aren't respecting card order correctly during the redraw. I suspect this is just an order parameter getting lost somewhere.

Jul 24 2019, 5:31 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20680: When a task card is edited, emit update events for old boards and parent boards.
Jul 24 2019, 5:29 PM · Workboards (v3), User Delight, Wikimedia

Jul 17 2019

epriestley added a revision to T4900: Workboards updating in real time: D20656: Make workboard real-time updates mostly work.
Jul 17 2019, 8:09 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

a logical clock to complement the wall-time clocks

Jul 17 2019, 6:25 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

From D20653:

Jul 17 2019, 6:15 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 6:04 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 5:53 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:39 PM · Workboards (v3), User Delight, Wikimedia

Jul 8 2019

epriestley updated the task description for T11036: Put subproject columns on workboards.
Jul 8 2019, 11:20 PM · Workboards (v3), Projects (v3)

Jul 3 2019

epriestley added a comment to T4900: Workboards updating in real time.

Just thinking out loud:

Jul 3 2019, 5:54 PM · Workboards (v3), User Delight, Wikimedia

Jul 2 2019

epriestley added a revision to T4900: Workboards updating in real time: D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Jul 2 2019, 8:58 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20638: Remove obsolete "options" from workboard "updateCard()" call.
Jul 2 2019, 5:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

Here's roughly where I'm headed next. I'm planning to:

Jul 2 2019, 5:18 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

The "default" controller currently needs to "force" the URI parameters...
The "filter" controller currently needs to "force" the URI parameters...
The "apply" flow, where a new custom filter is applied...

Jul 2 2019, 4:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20637: Remove remnants of clumsy old URI state handling from workboards.
Jul 2 2019, 4:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Jul 2 2019, 3:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Jul 2 2019, 2:43 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Jul 2 2019, 1:16 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20633: Move workboard "View as Query" workflow to a separate controller.
Jul 2 2019, 12:50 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20632: Move workboard "filter" workflow to a separate controller.
Jul 2 2019, 12:30 PM · Workboards (v3), User Delight, Wikimedia

Jun 29 2019

epriestley added a revision to T4900: Workboards updating in real time: D20629: Give the workboard "default" workflows more modern state handling.
Jun 29 2019, 10:35 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

A couple of weird cases on state management:

Jun 29 2019, 10:14 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jun 29 2019, 10:12 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20627: Remove property "id" from Workboard View controller.
Jun 29 2019, 9:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20626: Remove unused property "slug" from Workboard View controller.
Jun 29 2019, 8:07 PM · Workboards (v3), User Delight, Wikimedia

May 9 2019

igoldberg added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Got it, thanks for clarifying.

May 9 2019, 8:05 PM · Workboards (v3), Restricted Project
epriestley added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop). Is this expected / intentional?

May 9 2019, 6:54 PM · Workboards (v3), Restricted Project
igoldberg added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop).

May 9 2019, 6:51 PM · Workboards (v3), Restricted Project

Apr 13 2019

epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20417: Distinguish between "bad record format" and "bad record value" when validating Trigger rules.
Apr 13 2019, 4:33 PM · Workboards (v3)
epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20416: Improve trigger editor behavior when switching to/from tokenizers.
Apr 13 2019, 4:07 PM · Workboards (v3)

Apr 10 2019

pasik added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

ah, I missed that. I guess I should start testing this stuff soon :)

Apr 10 2019, 8:23 PM · Workboards (v3)
amckinley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

well, I'd say for example the "Close as <status> (only acts if task is not already closed)" is useful, and definitely needed.
Move the task to "done" column on the workboard, and the task automatically gets closed. That's handy.

Apr 10 2019, 7:36 PM · Workboards (v3)
pasik added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

well, I'd say for example the "Close as <status> (only acts if task is not already closed)" is useful, and definitely needed.
Move the task to "done" column on the workboard, and the task automatically gets closed. That's handy.

Apr 10 2019, 7:27 PM · Workboards (v3)
amckinley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20390: Add trigger rule to remove projects from tasks.
Apr 10 2019, 7:16 PM · Workboards (v3)
epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

Things feel pretty reasonable to me for now. I'm going to fix those bugs you hit and I think I have a couple other things I wanted to tweak, but I'm largely happy with the featureset as a v1.

Apr 10 2019, 6:55 PM · Workboards (v3)
amckinley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

Broadly, it's not clear to me that any of these rules are actually good/useful/worth building.

Apr 10 2019, 6:48 PM · Workboards (v3)
epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

Are these different from the existing implementation in PhabricatorProjectTriggerManiphestStatusRule?

Apr 10 2019, 6:40 PM · Workboards (v3)
amckinley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.
  • Close as <status> (only acts if task is not already closed).
  • Reopen as <status>.
Apr 10 2019, 6:27 PM · Workboards (v3)
amckinley updated the task description for T13269: Improve initial implementations of Workboard triggers and groups.
Apr 10 2019, 6:14 PM · Workboards (v3)

Apr 5 2019

amckinley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20379: Add trigger rule for adding projects to a task.
Apr 5 2019, 7:55 PM · Workboards (v3)

Mar 28 2019

epriestley moved T13074: Plans: Workboard triggers, groups, and subproject columns from Tentative to Next on the Plans board.
Mar 28 2019, 3:38 PM · Workboards (v3), Plans, Projects

Mar 27 2019

epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20329: Add a trigger rule to reassign a task.
Mar 27 2019, 6:02 PM · Workboards (v3)
epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20332: Give workboard column header actions a more clickable appearance.
Mar 27 2019, 2:07 PM · Workboards (v3)

Mar 26 2019

epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20331: On workboards, link ancestor project breadcrumbs to their workboards.
Mar 26 2019, 11:37 PM · Workboards (v3)
epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20330: Fix task hovercards showing a "Not Editable" state.
Mar 26 2019, 10:47 PM · Workboards (v3)
epriestley updated the task description for T13269: Improve initial implementations of Workboard triggers and groups.
Mar 26 2019, 7:52 PM · Workboards (v3)
epriestley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20326: When changing the trigger type in the trigger editor, properly redraw the control.
Mar 26 2019, 6:47 PM · Workboards (v3)
amckinley added a revision to T13269: Improve initial implementations of Workboard triggers and groups: D20325: Add workboard trigger rule for changing task priority.
Mar 26 2019, 6:40 PM · Workboards (v3)
epriestley updated the task description for T13269: Improve initial implementations of Workboard triggers and groups.
Mar 26 2019, 4:10 PM · Workboards (v3)
epriestley closed T12175: Simultaneous task moving on workboards results in error as Resolved by committing rP71c89bd0578d: Pass all adjacent card PHIDs from the client to the server when moving a card.
Mar 26 2019, 2:46 PM · Workboards (v3), Bug Report

Mar 25 2019

epriestley updated the task description for T13269: Improve initial implementations of Workboard triggers and groups.
Mar 25 2019, 9:26 PM · Workboards (v3)
epriestley updated the task description for T13269: Improve initial implementations of Workboard triggers and groups.
Mar 25 2019, 9:15 PM · Workboards (v3)
epriestley closed T5474: Support workboard column triggers which activate when a task is dropped into a column as Resolved.

This more or less exists, now. See T13269 for followups and T13074 for additional context.

Mar 25 2019, 9:12 PM · Workboards (v3), Restricted Project
epriestley triaged T13269: Improve initial implementations of Workboard triggers and groups as Normal priority.
Mar 25 2019, 8:20 PM · Workboards (v3)
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

See PHI119. PHI1128 is probably another copy of this, which suggests it's still a real bug.

Mar 25 2019, 7:57 PM · Workboards (v3), Plans, Projects
epriestley added a revision to T12175: Simultaneous task moving on workboards results in error: D20322: Pass all adjacent card PHIDs from the client to the server when moving a card.
Mar 25 2019, 7:17 PM · Workboards (v3), Bug Report
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20322: Pass all adjacent card PHIDs from the client to the server when moving a card.
Mar 25 2019, 7:17 PM · Workboards (v3), Plans, Projects
epriestley added a revision to T12175: Simultaneous task moving on workboards results in error: D20321: When moving cards on workboards, treat before/after cards as optional hints, not strict requirements.
Mar 25 2019, 5:49 PM · Workboards (v3), Bug Report
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20321: When moving cards on workboards, treat before/after cards as optional hints, not strict requirements.
Mar 25 2019, 5:49 PM · Workboards (v3), Plans, Projects
epriestley claimed T12175: Simultaneous task moving on workboards results in error.
Mar 25 2019, 5:31 PM · Workboards (v3), Bug Report
epriestley updated the task description for T13074: Plans: Workboard triggers, groups, and subproject columns.
Mar 25 2019, 4:43 PM · Workboards (v3), Plans, Projects
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

Simply adding two position rows on the same board doesn't reproduce the exact same error, we get this instead: [Unable to find...]

Mar 25 2019, 4:28 PM · Workboards (v3), Plans, Projects
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

Make drops when a column position already exists go through.

Mar 25 2019, 4:24 PM · Workboards (v3), Plans, Projects
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

See PHI119. This may describe a race fixed by chaos reduction in T13054. PHI1128 is probably another copy of this, which suggests it's still a real bug.
See PHI208. This describes a performance issue on workboards with very large numbers of tasks.

Mar 25 2019, 4:17 PM · Workboards (v3), Plans, Projects
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20320: Dim the action drop preview element when the cursor approaches.
Mar 25 2019, 3:09 PM · Workboards (v3), Restricted Project

Mar 22 2019

epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20308: Track how many columns use a particular trigger.
Mar 22 2019, 3:10 PM · Workboards (v3), Restricted Project

Mar 21 2019

epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20306: Add a "Play Sound" workboard trigger rule.
Mar 21 2019, 10:27 PM · Workboards (v3), Restricted Project
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20305: If the user cancels a workboard drop flow, put things back where they were.
Mar 21 2019, 8:41 PM · Workboards (v3), Plans, Projects
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20304: When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip.
Mar 21 2019, 8:24 PM · Workboards (v3), Restricted Project
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20303: Show a trigger rule summary on the rule view page.
Mar 21 2019, 7:31 PM · Workboards (v3), Restricted Project
epriestley closed T10336: Animate changes to workboards as Wontfix.

We may still pursue this, especially after T4900, but a lot of the use cases / needs are mostly theoretical and it's not clear they're actually necessary. Some of the actual solutions (like T10335) may largely provide enough clarity about these cases on their own. I'm currently planning to wait for feedback about recent and near-future changes (including triggers) and then fix whatever issues arise surgically -- possibly through animation, but possibly through other UI/UX remedies.

Mar 21 2019, 7:05 PM · Workboards (v3)
epriestley closed T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint as Resolved.

Those changes haven't landed yet but I'm just going to tidy this up a little early, see T13074 for followups.

Mar 21 2019, 7:00 PM · Workboards (v3)
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20302: Write workboard trigger rules to the database.
Mar 21 2019, 6:52 PM · Workboards (v3), Restricted Project
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20301: Mostly make the editor UI for triggers work.
Mar 21 2019, 4:43 PM · Workboards (v3), Restricted Project

Mar 20 2019

epriestley added a revision to T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint: D20300: Don't show workboard action previews if the action won't have any effect.
Mar 20 2019, 2:33 AM · Workboards (v3)

Mar 19 2019

epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20299: Preview the effects of a drag-and-drop operation on workboards.
Mar 19 2019, 11:09 PM · Workboards (v3), Restricted Project
epriestley added a revision to T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint: D20299: Preview the effects of a drag-and-drop operation on workboards.
Mar 19 2019, 11:09 PM · Workboards (v3)
epriestley claimed T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint.
Mar 19 2019, 11:02 PM · Workboards (v3)

Mar 15 2019

epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20288: Hard code a "close task" action on every column Trigger.
Mar 15 2019, 5:10 PM · Workboards (v3), Restricted Project

Mar 14 2019

epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20287: Allow triggers to be attached to and removed from workboard columns.
Mar 14 2019, 5:24 PM · Workboards (v3), Restricted Project
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20286: Modularize workboard column transactions.
Mar 14 2019, 3:23 PM · Workboards (v3), Restricted Project
kislinsk added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Very happy to see that you guys are working on this, thank you. 👍

Mar 14 2019, 8:32 AM · Workboards (v3), Restricted Project

Mar 13 2019

epriestley closed T10333: Add groups to workboard columns, a subtask of T8135: drag & drop on a workboard sorted by priority behavior is surprising, as Resolved.
Mar 13 2019, 11:12 AM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10333: Add groups to workboard columns as Resolved.

I'm going to consider this resolved at this point. The one thing I haven't built is the "task/point count" from the mocks (on the right-hand side of the header, counting points in each group), but I think this is probably only of much use under "Group by Owner", and maybe not even then. I'm open to building this in a future iteration and it's not likely to be very much work, I'd just like to see feedback that we're generally headed in the right direction first and that the element would have real-world use cases.

Mar 13 2019, 11:11 AM · Restricted Project, Restricted Project, Workboards (v3)

Mar 12 2019

epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20282: Allow "Move Tasks to Column..." to prompt for MFA.
Mar 12 2019, 9:20 PM · Workboards (v3), Plans, Projects
epriestley closed T10578: Provide 'Sort by Points' option in workboards as Resolved by committing rP03b7aca019d1: Implement "Sort by Points" on workboards.
Mar 12 2019, 8:54 PM · Workboards (v3), Feature Request
epriestley closed T10722: Communicate drag policies clearly in the workboard/list UIs as Resolved by committing rP804be81f5dbb: Provide better UI feedback about cards that can't be dragged or edited.
Mar 12 2019, 8:43 PM · Workboards (v3), Bug Report
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20279: Provide basic scaffolding for workboard column triggers.
Mar 12 2019, 6:15 PM · Workboards (v3), Restricted Project
epriestley added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Currently, you can put a task in a column in these ways:

Mar 12 2019, 1:37 PM · Workboards (v3), Restricted Project
epriestley added a revision to T10333: Add groups to workboard columns: D20278: Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort.
Mar 12 2019, 3:13 AM · Restricted Project, Restricted Project, Workboards (v3)

Mar 11 2019

epriestley added a revision to T10333: Add groups to workboard columns: D20277: Add "Group by Status" to Workboards.
Mar 11 2019, 9:23 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley claimed T10578: Provide 'Sort by Points' option in workboards.
Mar 11 2019, 4:53 PM · Workboards (v3), Feature Request
epriestley added a revision to T10578: Provide 'Sort by Points' option in workboards: D20276: Implement "Sort by Points" on workboards.
Mar 11 2019, 4:48 PM · Workboards (v3), Feature Request
epriestley added a revision to T10578: Provide 'Sort by Points' option in workboards: D20275: Add an "Sort by Creation Date" filter to workboards and modularize remaining order behaviors.
Mar 11 2019, 4:06 PM · Workboards (v3), Feature Request