Page MenuHomePhabricator
Differential D20416

Improve trigger editor behavior when switching to/from tokenizers
ClosedPublic
Actions

Authored by epriestley on Apr 13 2019, 4:07 PM.

Details

Reviewers
amckinley
Maniphest Tasks
T13269: Improve initial implementations of Workboard triggers and groups
Commits
rP9532bfbb32c8: Improve trigger editor behavior when switching to/from tokenizers
Summary

Ref T13269. See D20329. When we switch trigger rule control types, reset the rule value.

Also, pick slightly nicer defaults for status/priority.

Test Plan
  • Created a "Change Status To: X" rule.
  • Saved it.
  • Edited it.
  • Selected "Assign to" for the existing action's dropdown.
  • Before: tokenizer filled with nonsense.
  • After: tokenizer cleared.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 13 2019, 4:07 PM
Harbormaster completed remote builds in B22580: Diff 48710.Apr 13 2019, 4:09 PM
epriestley requested review of this revision.Apr 13 2019, 4:09 PM
epriestley added a child revision: D20417: Distinguish between "bad record format" and "bad record value" when validating Trigger rules.Apr 13 2019, 4:33 PM
amckinley accepted this revision.Apr 17 2019, 6:03 PM
This revision is now accepted and ready to land.Apr 17 2019, 6:03 PM
Closed by commit rP9532bfbb32c8: Improve trigger editor behavior when switching to/from tokenizers (authored by epriestley). · Explain WhyApr 17 2019, 7:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
project/
trigger/
2 lines
2 lines
webroot/
rsrc/
js/
application/
trigger/
19 lines

Diff 48759

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerManiphestPriorityRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php

Loading...
View Options

webroot/rsrc/js/application/trigger/TriggerRule.js

Loading...
Phabricator · Built by Phacility