Page MenuHomePhabricator

Modularize workboard column transactions
AcceptedPublic

Authored by epriestley on Thu, Mar 14, 3:22 PM.

Details

Summary

Depends on D20279. Ref T5474. Modernize these transactions before I add a new "TriggerTransaction" for setting triggers.

Test Plan

Created a column. Edited a column name and point limit. Hid and un-hid a column. Grepped for removed symbols.

Diff Detail

Repository
rP Phabricator
Branch
trigger2
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22288
Build 30481: Run Core Tests
Build 30480: arc lint + arc unit

Event Timeline

epriestley created this revision.Thu, Mar 14, 3:22 PM
epriestley requested review of this revision.Thu, Mar 14, 3:24 PM
epriestley added inline comments.Thu, Mar 14, 3:25 PM
src/applications/project/controller/PhabricatorProjectColumnEditController.php
96

This fixes a bug where this workflow didn't actually enforce the requirement that columns have a name.

amckinley accepted this revision.Mon, Mar 18, 6:57 PM
amckinley added inline comments.
src/applications/project/xaction/column/PhabricatorProjectColumnLimitTransaction.php
39

For consistency, "changed the point limit".

src/applications/project/xaction/column/PhabricatorProjectColumnStatusTransaction.php
22

"unhid this column"

26

"hid this column"

47

This is just going to be "0, 1"; maybe don't even bother to show it?

This revision is now accepted and ready to land.Mon, Mar 18, 6:57 PM