Page MenuHomePhabricator
Differential D20303

Show a trigger rule summary on the rule view page
ClosedPublic
Actions

Authored by epriestley on Mar 21 2019, 7:30 PM.
Tags
None
Referenced Files
F15470465: D20303.diff
Fri, Apr 4, 10:32 PM
F15459691: D20303.id48501.diff
Mon, Mar 31, 3:14 PM
F15457121: D20303.diff
Sun, Mar 30, 2:29 PM
F15457090: D20303.diff
Sun, Mar 30, 2:17 PM
F15457014: D20303.diff
Sun, Mar 30, 1:41 PM
F15456952: D20303.diff
Sun, Mar 30, 1:17 PM
F15456373: D20303.diff
Sun, Mar 30, 9:15 AM
F15456218: D20303.diff
Sun, Mar 30, 7:55 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T5474: Support workboard column triggers which activate when a task is dropped into a column
Commits
rP614f39b80679: Show a trigger rule summary on the rule view page
Summary

Ref T5474. When you view the main page for a rule, show what the rule does before you actually edit it.

Test Plan

Viewed a real trigger, then faked invalid/unknown rules:

Screen Shot 2019-03-21 at 12.20.39 PM.png (228×1 px, 35 KB)

Screen Shot 2019-03-21 at 12.25.51 PM.png (230×1 px, 42 KB)

Screen Shot 2019-03-21 at 12.27.04 PM.png (239×1 px, 48 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48501

View Options

src/applications/project/controller/trigger/PhabricatorProjectTriggerViewController.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTrigger.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerInvalidRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerUnknownRule.php

Loading...
Phabricator · Built by Phacility