Page MenuHomePhabricator

When a task card is edited, emit update events for old boards and parent boards
ClosedPublic

Authored by epriestley on Jul 24 2019, 5:29 PM.
Tags
None
Referenced Files
F18758768: D20680.id49323.diff
Sun, Oct 5, 11:32 PM
F18701302: D20680.diff
Sat, Sep 27, 6:17 PM
F18701264: D20680.diff
Sat, Sep 27, 6:07 PM
F18631197: D20680.diff
Sep 16 2025, 2:40 PM
F18631189: D20680.diff
Sep 16 2025, 2:39 PM
F18576838: D20680.id49323.diff
Sep 10 2025, 4:55 PM
F18567179: D20680.id.diff
Sep 9 2025, 3:34 PM
F18464491: D20680.id49333.diff
Sep 2 2025, 4:39 AM
Subscribers
None

Details

Summary

Ref T4900. When a card is edited, we currently emit an update notification for all the projects the task is tagged with. This isn't quite the right set:

  • We want to emit notifications for projects the task was previously tagged with, so it can be removed from boards it should no longer be part of.
  • We want to emit notifications for ancestors of projects the task is or was tagged with, so parent project boards can be updated.
  • However, we don't need to emit notifications for projects that don't actually have workboards.

Adjust the notification set to align better to these rules.

Test Plan
  • Removal of Parent Project: Edited a task on board "A > B", removing the "B" project tag. Saw board A update in another window.
  • Normal Update: Edited a task title on board X, saw board X update in another window.
  • Used bin/aphlict debug to inspect the notification set, saw generally sensible-seeming data going over the wire.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable