Page MenuHomePhabricator

When a task card is edited, emit update events for old boards and parent boards
ClosedPublic

Authored by epriestley on Jul 24 2019, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 10:19 PM
Unknown Object (File)
Mon, Dec 16, 7:01 PM
Unknown Object (File)
Thu, Nov 28, 11:17 PM
Unknown Object (File)
Tue, Nov 26, 10:42 AM
Unknown Object (File)
Nov 21 2024, 12:44 PM
Unknown Object (File)
Oct 24 2024, 4:40 AM
Unknown Object (File)
Oct 18 2024, 8:40 PM
Unknown Object (File)
Oct 17 2024, 8:33 PM
Subscribers
None

Details

Summary

Ref T4900. When a card is edited, we currently emit an update notification for all the projects the task is tagged with. This isn't quite the right set:

  • We want to emit notifications for projects the task was previously tagged with, so it can be removed from boards it should no longer be part of.
  • We want to emit notifications for ancestors of projects the task is or was tagged with, so parent project boards can be updated.
  • However, we don't need to emit notifications for projects that don't actually have workboards.

Adjust the notification set to align better to these rules.

Test Plan
  • Removal of Parent Project: Edited a task on board "A > B", removing the "B" project tag. Saw board A update in another window.
  • Normal Update: Edited a task title on board X, saw board X update in another window.
  • Used bin/aphlict debug to inspect the notification set, saw generally sensible-seeming data going over the wire.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable