Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state

Authored by epriestley on Mar 26 2019, 10:47 PM.



Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable