Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
F18169750: D20330.id48525.diff
Fri, Aug 15, 5:27 PM
F18110214: D20330.id48524.diff
Mon, Aug 11, 5:19 PM
F18103797: D20330.id.diff
Sun, Aug 10, 7:52 AM
F18100081: D20330.diff
Sat, Aug 9, 10:50 AM
F17969889: D20330.id48524.diff
Aug 1 2025, 2:29 PM
F17922969: D20330.diff
Jul 30 2025, 7:34 AM
F17844485: D20330.id48525.diff
Jul 27 2025, 2:13 AM
F17828353: D20330.diff
Jul 26 2025, 9:06 AM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable