Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
F15571069: D20330.diff
Mon, May 5, 4:08 AM
F15562790: D20330.id48524.diff
Wed, Apr 30, 4:21 AM
F15540497: D20330.id.diff
Fri, Apr 25, 7:52 AM
F15536316: D20330.diff
Thu, Apr 24, 9:02 AM
F15533575: D20330.id48525.diff
Wed, Apr 23, 8:37 PM
F15465795: D20330.id48525.diff
Apr 2 2025, 11:14 PM
F15452797: D20330.diff
Mar 29 2025, 7:17 AM
F15445682: D20330.id48524.diff
Mar 27 2025, 3:28 PM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable