Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
F15431053: D20330.diff
Mon, Mar 24, 10:14 AM
F15425154: D20330.diff
Sun, Mar 23, 2:46 AM
F15332143: D20330.id.diff
Fri, Mar 7, 4:36 PM
F15331456: D20330.id48525.diff
Fri, Mar 7, 10:31 AM
F15282621: D20330.diff
Tue, Mar 4, 12:41 AM
Unknown Object (File)
Feb 15 2025, 3:01 AM
Unknown Object (File)
Feb 15 2025, 2:35 AM
Unknown Object (File)
Feb 15 2025, 2:35 AM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable