Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
F18750232: D20330.id.diff
Sat, Oct 4, 7:02 AM
F18740690: D20330.id48524.diff
Thu, Oct 2, 4:35 AM
F18671910: D20330.id48525.diff
Thu, Sep 25, 5:53 AM
F18591333: D20330.diff
Fri, Sep 12, 8:57 AM
F18518476: D20330.diff
Sep 5 2025, 3:17 PM
F18169750: D20330.id48525.diff
Aug 15 2025, 5:27 PM
F18110214: D20330.id48524.diff
Aug 11 2025, 5:19 PM
F18103797: D20330.id.diff
Aug 10 2025, 7:52 AM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable