Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
F18852778: D20330.diff
Fri, Oct 31, 11:50 AM
F18829511: D20330.diff
Oct 24 2025, 10:35 PM
F18788546: D20330.id48525.diff
Oct 15 2025, 5:23 AM
F18769494: D20330.id48524.diff
Oct 8 2025, 7:51 AM
F18766087: D20330.id48524.diff
Oct 7 2025, 2:53 PM
F18750232: D20330.id.diff
Oct 4 2025, 7:02 AM
F18740690: D20330.id48524.diff
Oct 2 2025, 4:35 AM
F18671910: D20330.id48525.diff
Sep 25 2025, 5:53 AM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable