Page MenuHomePhabricator

Implement "Sort by Points" on workboards
ClosedPublic

Authored by epriestley on Mar 11 2019, 4:48 PM.

Details

Summary

Depends on D20275. Fixes T10578. This is a static sorting (like "By Date Created") where you can't change point values by dragging. You can still drag cards between columns, or use the "Edit" icon to change point values.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 11 2019, 4:48 PM
epriestley requested review of this revision.Mar 11 2019, 4:49 PM

This is a static sorting (like "By Date Created") where you can't change point values by dragging.

This is still a little more sensical than changing the date created though, isn't it?

src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php
30–32

This is going to conflict with D20281 but I'm sure you're on top of it.

src/applications/project/order/PhabricatorProjectColumnPointsOrder.php
14

fa-ellipsis-h? fa-cubes? fa-exclamation-circle? fa-map-pin? I think I like fa-map-pin the best. This concludes today's bike shedding.

37

Is this to call out, uh, "pointless" tasks to encourage someone to assign some points to them?

amckinley accepted this revision.Mar 12 2019, 8:33 PM
This revision is now accepted and ready to land.Mar 12 2019, 8:33 PM

This is still a little more sensical than changing the date created though, isn't it?

Changing point values is definitely an actual operation. The major issue is that if you drag a card between other cards with values "10" and "39,000", what value do we assign? 10? 39,000? 11? 38,999? Average them to produce 19,505? All these answers are probably wrong under some schemes like "Always Assign Fibonacci Numbers as Costs" which is a Real Thing that has a wiki page:

https://en.wikipedia.org/wiki/Fibonacci_scale_(agile)

I think the only good answer is probably "Prompt the user to pick a number between 10 and 39,000 inclusive", but I think they probably might as well just click the edit icon to do that anyway. We could tweak this if we get a pile of feedback or something (or let you configure a discrete set of possible point values, then put headers on this view if you do) since there's no fundamental problem with the underlying operation.

src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php
30–32

Yeah, D20281 is way at the end of this sequence.

src/applications/project/order/PhabricatorProjectColumnPointsOrder.php
37

Yeah, similar to how "Unowned" tasks are on top and "Needs Triage" is the highest priority.

epriestley updated this revision to Diff 48412.Mar 12 2019, 8:49 PM
  • Use "fa-map-pin", which I guess is sort of a pun about "points" on a map?
This revision was automatically updated to reflect the committed changes.