Page MenuHomePhabricator

When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip
ClosedPublic

Authored by epriestley on Mar 21 2019, 8:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2024, 6:38 AM
Unknown Object (File)
Feb 3 2024, 9:48 PM
Unknown Object (File)
Jan 20 2024, 6:07 PM
Unknown Object (File)
Jan 20 2024, 5:29 PM
Unknown Object (File)
Dec 26 2023, 8:53 AM
Unknown Object (File)
Dec 23 2023, 7:24 PM
Unknown Object (File)
Dec 3 2023, 6:39 AM
Unknown Object (File)
Nov 29 2023, 10:53 PM
Subscribers
None

Details

Summary

Ref T5474. The first rough cut of triggers showed some of the trigger rules in a tooltip when you hover over the "add/remove" trigger menu.

This isn't great since we don't have much room and it's a bit finnicky / hard to read.

Since we have a better way to show effects now in the drop preview, just use that instead. When you hover over the trigger menu, preview the trigger in the "drop effect" element, with a "Trigger: such-and-such" header.

Test Plan
  • This is pretty tough to screenshot.
  • Hovered over menu, got a sensible preview of the trigger effects.
  • Dragged a card over the menu, no preview.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable