Page MenuHomePhabricator

When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip
ClosedPublic

Authored by epriestley on Mar 21 2019, 8:23 PM.
Tags
None
Referenced Files
F15435690: D20304.diff
Tue, Mar 25, 9:45 AM
F15430358: D20304.id48458.diff
Mon, Mar 24, 7:16 AM
F15428756: D20304.id48502.diff
Sun, Mar 23, 10:07 PM
F15427698: D20304.id48502.diff
Sun, Mar 23, 3:40 PM
F15422554: D20304.diff
Sat, Mar 22, 9:19 AM
F15421659: D20304.id48458.diff
Sat, Mar 22, 1:33 AM
F15421652: D20304.id48502.diff
Sat, Mar 22, 1:32 AM
F15414942: D20304.diff
Thu, Mar 20, 3:12 AM
Subscribers
None

Details

Summary

Ref T5474. The first rough cut of triggers showed some of the trigger rules in a tooltip when you hover over the "add/remove" trigger menu.

This isn't great since we don't have much room and it's a bit finnicky / hard to read.

Since we have a better way to show effects now in the drop preview, just use that instead. When you hover over the trigger menu, preview the trigger in the "drop effect" element, with a "Trigger: such-and-such" header.

Test Plan
  • This is pretty tough to screenshot.
  • Hovered over menu, got a sensible preview of the trigger effects.
  • Dragged a card over the menu, no preview.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable