Page MenuHomePhabricator

When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip
ClosedPublic

Authored by epriestley on Mar 21 2019, 8:23 PM.

Details

Summary

Ref T5474. The first rough cut of triggers showed some of the trigger rules in a tooltip when you hover over the "add/remove" trigger menu.

This isn't great since we don't have much room and it's a bit finnicky / hard to read.

Since we have a better way to show effects now in the drop preview, just use that instead. When you hover over the trigger menu, preview the trigger in the "drop effect" element, with a "Trigger: such-and-such" header.

Test Plan
  • This is pretty tough to screenshot.
  • Hovered over menu, got a sensible preview of the trigger effects.
  • Dragged a card over the menu, no preview.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 21 2019, 8:23 PM
epriestley requested review of this revision.Mar 21 2019, 8:24 PM
amckinley accepted this revision.Mar 25 2019, 8:56 PM
This revision is now accepted and ready to land.Mar 25 2019, 8:56 PM
This revision was automatically updated to reflect the committed changes.