Page MenuHomePhabricator

Dim the action drop preview element when the cursor approaches
ClosedPublic

Authored by epriestley on Mar 25 2019, 3:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 7:31 AM
Unknown Object (File)
Sat, Feb 24, 3:21 PM
Unknown Object (File)
Feb 3 2024, 9:50 PM
Unknown Object (File)
Jan 18 2024, 7:16 AM
Unknown Object (File)
Dec 28 2023, 2:39 AM
Unknown Object (File)
Dec 3 2023, 11:54 AM
Unknown Object (File)
Nov 29 2023, 10:54 PM
Unknown Object (File)
Nov 26 2023, 11:06 AM
Subscribers
None

Details

Summary

Depends on D20308. Ref T5474. The element which previews what will happen when you drop a task somewhere can cover the bottom part of the rightmost column on a workboard.

To fix this, I'm trying to just fade it out if you put your cursor over it. I tried to do this in a simple way previously (":hover" + "opacity: 0.25") but it doesn't actually work because "pointer-events: none" stops ":hover" from working.

Instead, do this in Javascript. This is a little more complicated but: it works; and we can do the fade when you get near the element instead of actually over it, which feels a little better.

Test Plan
  • Shrank window to fairly small size so that the preview could cover up stuff on the workboard.
  • Dragged a card toward the rightmost column.
  • Before: drop action preview covered some workboard stuff.
  • After: preview faded out as my cursor approached.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I wonder if we should buy some $20 screen recording software for showing "screenshots" for stuff like this... No idea what the current State of the Art is for that stuff on Mac.

This revision is now accepted and ready to land.Mar 25 2019, 9:33 PM
This revision was automatically updated to reflect the committed changes.