Page MenuHomePhabricator

When changing the trigger type in the trigger editor, properly redraw the control
ClosedPublic

Authored by epriestley on Mar 26 2019, 6:47 PM.
Tags
None
Referenced Files
F18741209: D20326.id.diff
Thu, Oct 2, 9:18 AM
F18739774: D20326.diff
Wed, Oct 1, 10:54 PM
F18646920: D20326.id48517.diff
Fri, Sep 19, 11:38 AM
F18591364: D20326.diff
Fri, Sep 12, 9:03 AM
F18591319: D20326.diff
Fri, Sep 12, 8:54 AM
F18518452: D20326.diff
Sep 5 2025, 3:16 PM
F17922950: D20326.diff
Jul 30 2025, 7:33 AM
Unknown Object (File)
May 5 2025, 3:30 AM
Subscribers
None

Details

Summary

Ref T13269. I refactored this late in the game to organize things better and add table cells around stuff, and accidentally broke the relationship between the "Rule Type" selector and the value selector.

Test Plan

Switched rule type selector from "Change Status" to "Play Sound", saw secondary control update properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable