Page MenuHomePhabricator

If the user cancels a workboard drop flow, put things back where they were
ClosedPublic

Authored by epriestley on Mar 21 2019, 8:41 PM.

Details

Summary

Ref T13074. If you hit a prompt on a drop operation (today: MFA; in the future, maybe "add a comment" or "assign this task"), we currently leave the board in a bad semi-frozen state if you cancel the workflow by pressing "Cancel" on the dialog.

Instead, put things back the way they were.

Test Plan

Dragged an MFA-required card, cancelled the MFA prompt, got a functional board instead of a semi-frozen board I needed to reload.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
webroot/rsrc/js/application/projects/WorkboardBoard.js
517

Should this have a corresponding lock() somewhere?

This revision is now accepted and ready to land.Mar 25 2019, 8:57 PM
webroot/rsrc/js/application/projects/WorkboardBoard.js
517

The paired lock() happens when you first pick up the card.

We unlock() on success (below, in _oncardupdate()) already, this just adds an unlock when we complete the drag but have failed.

This revision was automatically updated to reflect the committed changes.