Page MenuHomePhabricator

Add a "Play Sound" workboard trigger rule
ClosedPublic

Authored by epriestley on Mar 21 2019, 10:26 PM.
Tags
None
Referenced Files
F12588677: D20306.id48488.diff
Mon, Mar 18, 11:58 AM
Unknown Object (File)
Feb 8 2024, 3:21 PM
Unknown Object (File)
Feb 3 2024, 9:48 PM
Unknown Object (File)
Feb 1 2024, 5:35 PM
Unknown Object (File)
Jan 29 2024, 3:11 PM
Unknown Object (File)
Jan 11 2024, 6:32 AM
Unknown Object (File)
Dec 19 2023, 3:09 AM
Unknown Object (File)
Dec 4 2023, 11:55 AM
Subscribers
None

Details

Summary

Ref T5474. Allow columns to play a sound when tasks are dropped.

This is a little tricky because Safari has changed somewhat recently to require some gymnastics to play sounds when the user didn't explicitly click something. Preloading the sound on the first mouse interaction, then playing and immediately pausing it seems to work, though.

Test Plan

Added a trigger with 5 sounds. In Safari, Chrome, and Firefox, dropped a card into the column. In all browsers, heard a nice sequence of 5 sounds played one after the other.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
webroot/rsrc/js/application/projects/behavior-project-boards.js
172

This callback only gets triggered on the first mousedown, right?

This revision is now accepted and ready to land.Mar 25 2019, 6:31 PM
webroot/rsrc/js/application/projects/behavior-project-boards.js
172

It runs on each click, but sounds is empty after the first time so it's effectively a no-op.

(There's currently no super convenient way to do a listenOnce() kind of thing. The callback could unregister the listener, but the cost of keeping this callback around should be insignificant.)

  • Instead of doing sounds = [], just do listener.remove() to remove the listener.
This revision was automatically updated to reflect the committed changes.