Page MenuHomePhabricator

Track how many columns use a particular trigger
ClosedPublic

Authored by epriestley on Mar 22 2019, 3:09 PM.
Tags
None
Referenced Files
F18817045: D20308.id.diff
Tue, Oct 21, 11:43 AM
F18753064: D20308.id48462.diff
Sat, Oct 4, 5:19 PM
F18682206: D20308.id.diff
Sep 26 2025, 5:22 AM
F18653139: D20308.diff
Sep 21 2025, 11:20 AM
F18518391: D20308.diff
Sep 5 2025, 3:12 PM
F18462145: D20308.id.diff
Sep 1 2025, 9:42 PM
F18458965: D20308.id48462.diff
Sep 1 2025, 3:52 PM
F18458004: D20308.diff
Sep 1 2025, 1:31 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T5474. In 99% of cases, a separate "archived/active" status for triggers probably doesn't make much sense: there's not much reason to ever disable/archive a trigger explcitly, and the archival rule is really just "is this trigger used by anything?".

(The one reason I can think of to disable a trigger manually is because you want to put something in a column and skip trigger rules, but you can already do this from the task detail page anyway, and disabling the trigger globally is a bad way to accomplish this if it's in use by other columns.)

Instead of adding a separate "status", just track how many columns a trigger is used by and consider it "inactive" if it is not used by any active columns.

Test Plan

This is slightly hard to test exhaustively since you can't share a trigger across multiple columns right now, but: rebuild indexes, poked around the trigger list and trigger details, added/removed triggers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable