(experimental) Merge branch 'master' into experimental
Audit Required56e3232c56e4
Actions

Description

(experimental) Merge branch 'master' into experimental

Details

Group Auditors

Provenance

epriestley	Authored on Sep 27 2017, 3:16 PM
epriestley	Pushed on Sep 27 2017, 3:16 PM

Parents

rARCc804c5026011: Don't show a blank line if there is no user data
rARC14150123acae: Add explicit limits to unit test/lint error names

Branches

Unknown

Tags

Unknown

Build Status

Buildable 18550
Build 24991: Run Core Tests

Event Timeline

epriestley committed rARC56e3232c56e4: (experimental) Merge branch 'master' into experimental (authored by epriestley).Sep 27 2017, 3:16 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptSep 27 2017, 3:16 PM

This commit now requires audit.Sep 27 2017, 3:16 PM

Harbormaster completed building B18550: rARC56e3232c56e4: (experimental) Merge branch 'master' into experimental.Sep 27 2017, 3:17 PM

Merged Changes

c804c5026011 Don't show a blank line if there is no user data
Author
alexmv
Revisions
D18632: Don't show a blank line if there is no user data
Browse Repository
Passed
No Audits
b836557b12b3 Correct lint rendering when patching trailing whitespace in files
Author
epriestley
Revisions
D18631: Correct lint rendering when patching trailing whitespace in files
Browse Repository
Passed
No Audits
df81d79d77f8 Add explicit limits to unit test/lint error names
Author
amckinley
Revisions
D18603: Add explicit limits to unit test/lint error names
Browse Repository
Passed
No Audits
cbc785ddce71 Fix a similar lint rendering issue when trimming identical lines out of patches
Author
epriestley
Revisions
D18541: Fix a similar lint rendering issue when trimming identical lines out of patches
Browse Repository
Passed
No Audits
7371277d2065 Fix a prefix/suffix counting issue in Arcanist lint rendering
Author
epriestley
Revisions
D18538: Fix a prefix/suffix counting issue in Arcanist lint rendering
Browse Repository
Passed
No Audits
d9cb5b18fbc1 Cheat our way through `arc version` on Windows for the moment
Author
epriestley
Revisions
D18518: Cheat our way through `arc version` on Windows for the moment
Browse Repository
Passed
No Audits
ad8214456add Restore ANSI highlighting of lint sections to lint output
Author
epriestley
Revisions
D18512: Restore ANSI highlighting of lint sections to lint output
Browse Repository
Passed
No Audits
213ed3ff15d7 Restore the caret pointer ("^") for lint lines which only have a character…
Author
epriestley
Revisions
D18511: Restore the caret pointer ("^") for lint lines which only have a character offset
Browse Repository
Passed
No Audits
86779b152654 Render lint patches which have newlines in a less misleading way
Author
epriestley
Revisions
D18510: Render lint patches which have newlines in a less misleading way
Browse Repository
Passed
No Audits
be67df611856 Extract and cover the logic for "trimming" a lint message
Author
epriestley
Revisions
D18509: Extract and cover the logic for "trimming" a lint message
Browse Repository
Passed
No Audits
ab0d81bca292 Add basic test coverage for lint console rendering
Author
epriestley
Revisions
D18508: Add basic test coverage for lint console rendering
Browse Repository
Passed
No Audits
5eda40337bb4 Fix missing whitespace in `arc linters --help` message
Author
alexmv
Revisions
D18344: Fix missing whitespace in `arc linters --help` message
Browse Repository
Passed
No Audits
836768bdccd4 Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out
Author
asherkin
Revisions
D18271: Fix ArcanistPHPCloseTagXHPASTLinterRule always bailing out
Browse Repository
Passed
No Audits
7bb8dbabce83 Reduce the strength of "arc executing on arc" from an error to a warning
Author
epriestley
Revisions
D18264: Reduce the strength of "arc executing on arc" from an error to a warning
Browse Repository
Passed
No Audits
165df12046e5 Consistently use `phutil_console_confirm()`.
Author
stefren
Revisions
D18185: Consistently use `phutil_console_confirm()`.
Browse Repository
Passed
No Audits
c04f141ab023 Remove obsolete "arc land" flags: --update-with-merge/rebase, --delete-remote
Author
epriestley
Revisions
D18108: Remove obsolete "arc land" flags: --update-with-merge/rebase, --delete-remote
Browse Repository
Passed
No Audits
129d51fa0936 If the base commit for `arc patch` does not exist locally, try to fetch it
Author
alexmv
Revisions
D17949: If the base commit for `arc patch` does not exist locally, try to fetch it
Browse Repository
Passed
No Audits
3c4735795a29 Detect trailing spaces and tabs
Author
johnny-bit
Revisions
D17814: Detect trailing spaces and tabs
Browse Repository
Passed
No Audits
27b51e619237 Fix two minor issues with "arc download"
Author
epriestley
Revisions
D17800: Fix two minor issues with "arc download"
Browse Repository
Passed
No Audits
5d0f5afca8cd Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
Author
amckinley
Revisions
D17787: Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
Browse Repository
Passed
No Audits
146693307f60 Make exception reporting from `arc` be in red
Author
alexmv
Revisions
D17748: Make exception reporting from `arc` be in red
Browse Repository
Passed
No Audits
a59cfca5f190 Upgrade "arc upload" to use SHA256
Author
epriestley
Revisions
D17622: Upgrade "arc upload" to use SHA256
Browse Repository
Passed
No Audits
c4e84550fcd3 Allow "arc upload" to work correctly if it can not hash content
Author
epriestley
Revisions
D17621: Allow "arc upload" to work correctly if it can not hash content
Browse Repository
Passed
No Audits
82b7cd778a28 Make "arc download" use "file.search" if available
Author
epriestley
Revisions
D17614: Make "arc download" use "file.search" if available
Browse Repository
Passed
No Audits
d1db9a72b552 Improve the flake8 line-matching regex
Author
jparise
Revisions
D17552: Improve the flake8 line-matching regex
Browse Repository
Passed
No Audits
3b6b523c2b23 Fix errors found by PHPStan
Author
vrana
Revisions
D17376: Fix errors found by PHPStan
Browse Repository
Passed
No Audits
d0353d238113 Fix errors found by PHPStan
Author
vrana
Revisions
D17367: Fix errors found by PHPStan
Browse Repository
Passed
No Audits
460b0e46eea0 Fix a property name collision in ArcanistHgServerChannel
Author
epriestley
Revisions
D17366: Fix a property name collision in ArcanistHgServerChannel
Browse Repository
Passed
No Audits
13596cd10fbe Add back pht()s and tsprintf()s to arg set-config
Author
avivey
Revisions
D17362: Add back pht()s and tsprintf()s to arg set-config
Browse Repository
Passed
No Audits
bc9b70508edf arc set-config: warn about unknown keys
Author
avivey
Revisions
D17357: arc set-config: warn about unknown keys
Browse Repository
Passed
No Audits
f3037bf216e5 [git] Override `diff.submodule` so `git diff` output is always parseable
Author
alexmv
Revisions
D17327: [git] Override `diff.submodule` so `git diff` output is always parseable
Browse Repository
Passed
No Audits
224986af634e Provide a better error message when an invalid ID is given to arc patch
Author
jcox
Revisions
D17325: Provide a better error message when an invalid ID is given to arc patch
Browse Repository
Passed
No Audits
ade25facfdf2 Fix a bad interaction between "arc diff --reviewers" and "the first line of a…
Author
epriestley
Revisions
D17147: Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
Browse Repository
Passed
No Audits
c243cbbd9fc7 tighten remote URI error handling with idiosyncratic remote names
Author
cburroughs
Revisions
D17110: tighten remote URI error handling with idiosyncratic remote names
Browse Repository
Passed
No Audits

Changes (73)

Path

Size

scripts/

arcanist.php

src/

__phutil_library_map__.php

configuration/

ArcanistSettings.php

hgdaemon/

ArcanistHgServerChannel.php

land/

ArcanistGitLandEngine.php

lint/

ArcanistLintMessage.php

__tests__

ArcanistLintMessageTestCase.php

linter/

ArcanistBaseXHPASTLinter.php

ArcanistFlake8Linter.php

ArcanistTextLinter.php

__tests__/

ArcanistClosureLinterTestCase.php

text/

	trailing-whitespace-1.lint-test
	trailing-whitespace.lint-test

trailing-whitespace-2.lint-test

trailing-whitespace-3.lint-test

trailing-whitespace.lint-test

xhpast/

empty.lint-test

xml/

attr2.lint-test

standards/

phutil/

ArcanistPhutilXHPASTLinterStandard.php

xhpast/

rules/

ArcanistPHPCloseTagXHPASTLinterRule.php

ArcanistPHPCompatibilityXHPASTLinterRule.php

__tests__/

ArcanistPHPCloseTagXHPASTLinterRuleTestCase.php

php-close-tag

php-close-tag-inline-html-good.lint-test

	php-close-tag/
	extract-use/

	php-close-tag.lint-test
	extract-use.lint-test

renderer/

ArcanistConsoleLintRenderer.php

__tests__

ArcanistConsoleLintRendererTestCase.php

extrawhitespace.expect

repository/

api/

ArcanistGitAPI.php

ArcanistMercurialAPI.php

ArcanistRepositoryAPI.php

unit/

engine/

XUnitTestEngine.php

parser/

__tests__/

XUnitTestResultParserTestCase.php

renderer/

ArcanistUnitConsoleRenderer.php

upload/

ArcanistFileDataRef.php

workflow/

ArcanistDiffWorkflow.php

ArcanistDownloadWorkflow.php

ArcanistLandWorkflow.php

ArcanistLintWorkflow.php

ArcanistLintersWorkflow.php

ArcanistPatchWorkflow.php

ArcanistSetConfigWorkflow.php

ArcanistStartWorkflow.php

ArcanistStopWorkflow.php

ArcanistTasksWorkflow.php

ArcanistUnitWorkflow.php

ArcanistVersionWorkflow.php

ArcanistWorkflow.php

rARC56e3232c56e4

View Options

scripts/arcanist.php

View Options

src/__phutil_library_map__.php

View Options

src/configuration/ArcanistSettings.php

View Options

src/hgdaemon/ArcanistHgServerChannel.php

View Options

src/land/ArcanistGitLandEngine.php

View Options

src/lint/ArcanistLintMessage.php

View Options

src/lint/tests/ArcanistLintMessageTestCase.php

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php

View Options

src/lint/linter/ArcanistFlake8Linter.php

View Options

src/lint/linter/ArcanistTextLinter.php

View Options

src/lint/linter/tests/ArcanistClosureLinterTestCase.php

View Options

src/lint/linter/tests/text/trailing-whitespace-1.lint-test

View Options

src/lint/linter/tests/text/trailing-whitespace-2.lint-test

View Options

src/lint/linter/tests/text/trailing-whitespace-3.lint-test

View Options

src/lint/linter/tests/text/trailing-whitespace.lint-test

View Options

src/lint/linter/tests/xhpast/empty.lint-test

View Options

src/lint/linter/tests/xml/attr2.lint-test

View Options

src/lint/linter/standards/phutil/ArcanistPhutilXHPASTLinterStandard.php

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCloseTagXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistPHPCloseTagXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/php-close-tag/php-close-tag-inline-html-good.lint-test

View Options

src/lint/linter/xhpast/rules/tests/php-close-tag/php-close-tag.lint-test

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

View Options

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

View Options

src/lint/renderer/tests/data/addline.expect

View Options

src/lint/renderer/tests/data/addline.txt

View Options

src/lint/renderer/tests/data/addlinesuffix.expect

View Options

src/lint/renderer/tests/data/addlinesuffix.txt

View Options

src/lint/renderer/tests/data/caret.expect

View Options

src/lint/renderer/tests/data/caret.txt

View Options

src/lint/renderer/tests/data/extrawhitespace.expect

View Options

src/lint/renderer/tests/data/extrawhitespace.txt

View Options

src/lint/renderer/tests/data/inline.expect

View Options

src/lint/renderer/tests/data/inline.txt

View Options

src/lint/renderer/tests/data/midline.expect

View Options

src/lint/renderer/tests/data/midline.txt

View Options

src/lint/renderer/tests/data/newline.expect

View Options

src/lint/renderer/tests/data/newline.txt

View Options

src/lint/renderer/tests/data/original.expect

View Options

src/lint/renderer/tests/data/original.txt

View Options

src/lint/renderer/tests/data/overlap.expect

View Options

src/lint/renderer/tests/data/overlap.txt

View Options

src/lint/renderer/tests/data/remline.expect

View Options

src/lint/renderer/tests/data/remline.txt

View Options

src/lint/renderer/tests/data/simple.expect

View Options

src/lint/renderer/tests/data/simple.txt

View Options

src/lint/renderer/tests/data/xml.expect

View Options

src/lint/renderer/tests/data/xml.txt

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/api/ArcanistMercurialAPI.php

View Options

src/repository/api/ArcanistRepositoryAPI.php

View Options

src/unit/engine/XUnitTestEngine.php

View Options

src/unit/parser/tests/XUnitTestResultParserTestCase.php

View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

View Options

src/upload/ArcanistFileDataRef.php

View Options

src/workflow/ArcanistDiffWorkflow.php

View Options

src/workflow/ArcanistDownloadWorkflow.php

View Options

src/workflow/ArcanistLandWorkflow.php

View Options

src/workflow/ArcanistLintWorkflow.php

View Options

src/workflow/ArcanistLintersWorkflow.php

View Options

src/workflow/ArcanistPatchWorkflow.php

View Options

src/workflow/ArcanistSetConfigWorkflow.php

View Options

src/workflow/ArcanistStartWorkflow.php

View Options

src/workflow/ArcanistStopWorkflow.php

View Options

src/workflow/ArcanistTasksWorkflow.php

View Options

src/workflow/ArcanistUnitWorkflow.php

View Options

src/workflow/ArcanistVersionWorkflow.php

View Options

src/workflow/ArcanistWorkflow.php

(experimental) Merge branch 'master' into experimentalAudit Required56e3232c56e4Actions

Description

Details

Event Timeline

Merged Changes

Changes (73)

rARC56e3232c56e4

scripts/arcanist.php

src/__phutil_library_map__.php

src/configuration/ArcanistSettings.php

src/hgdaemon/ArcanistHgServerChannel.php

src/land/ArcanistGitLandEngine.php

src/lint/ArcanistLintMessage.php

src/lint/__tests__/ArcanistLintMessageTestCase.php

src/lint/linter/ArcanistBaseXHPASTLinter.php

src/lint/linter/ArcanistFlake8Linter.php

src/lint/linter/ArcanistTextLinter.php

src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php

src/lint/linter/__tests__/text/trailing-whitespace-1.lint-test

src/lint/linter/__tests__/text/trailing-whitespace-2.lint-test

src/lint/linter/__tests__/text/trailing-whitespace-3.lint-test

src/lint/linter/__tests__/text/trailing-whitespace.lint-test

src/lint/linter/__tests__/xhpast/empty.lint-test

src/lint/linter/__tests__/xml/attr2.lint-test

src/lint/linter/standards/phutil/ArcanistPhutilXHPASTLinterStandard.php

src/lint/linter/xhpast/rules/ArcanistPHPCloseTagXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPCloseTagXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/php-close-tag/php-close-tag-inline-html-good.lint-test

src/lint/linter/xhpast/rules/__tests__/php-close-tag/php-close-tag.lint-test

src/lint/renderer/ArcanistConsoleLintRenderer.php

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/__tests__/data/addline.expect

src/lint/renderer/__tests__/data/addline.txt

src/lint/renderer/__tests__/data/addlinesuffix.expect

src/lint/renderer/__tests__/data/addlinesuffix.txt

src/lint/renderer/__tests__/data/caret.expect

src/lint/renderer/__tests__/data/caret.txt

src/lint/renderer/__tests__/data/extrawhitespace.expect

src/lint/renderer/__tests__/data/extrawhitespace.txt

src/lint/renderer/__tests__/data/inline.expect

src/lint/renderer/__tests__/data/inline.txt

src/lint/renderer/__tests__/data/midline.expect

src/lint/renderer/__tests__/data/midline.txt

src/lint/renderer/__tests__/data/newline.expect

src/lint/renderer/__tests__/data/newline.txt

src/lint/renderer/__tests__/data/original.expect

src/lint/renderer/__tests__/data/original.txt

src/lint/renderer/__tests__/data/overlap.expect

src/lint/renderer/__tests__/data/overlap.txt

src/lint/renderer/__tests__/data/remline.expect

src/lint/renderer/__tests__/data/remline.txt

src/lint/renderer/__tests__/data/simple.expect

src/lint/renderer/__tests__/data/simple.txt

src/lint/renderer/__tests__/data/xml.expect

src/lint/renderer/__tests__/data/xml.txt

src/repository/api/ArcanistGitAPI.php

src/repository/api/ArcanistMercurialAPI.php

src/repository/api/ArcanistRepositoryAPI.php

src/unit/engine/XUnitTestEngine.php

src/unit/parser/__tests__/XUnitTestResultParserTestCase.php

src/unit/renderer/ArcanistUnitConsoleRenderer.php

src/upload/ArcanistFileDataRef.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistDownloadWorkflow.php

src/workflow/ArcanistLandWorkflow.php

src/workflow/ArcanistLintWorkflow.php

src/workflow/ArcanistLintersWorkflow.php

src/workflow/ArcanistPatchWorkflow.php

src/workflow/ArcanistSetConfigWorkflow.php

src/workflow/ArcanistStartWorkflow.php

src/workflow/ArcanistStopWorkflow.php

src/workflow/ArcanistTasksWorkflow.php

src/workflow/ArcanistUnitWorkflow.php

src/workflow/ArcanistVersionWorkflow.php

src/workflow/ArcanistWorkflow.php

(experimental) Merge branch 'master' into experimental
Audit Required56e3232c56e4
Actions

src/lint/tests/ArcanistLintMessageTestCase.php

src/lint/linter/tests/ArcanistClosureLinterTestCase.php

src/lint/linter/tests/text/trailing-whitespace-1.lint-test

src/lint/linter/tests/text/trailing-whitespace-2.lint-test

src/lint/linter/tests/text/trailing-whitespace-3.lint-test

src/lint/linter/tests/text/trailing-whitespace.lint-test

src/lint/linter/tests/xhpast/empty.lint-test

src/lint/linter/tests/xml/attr2.lint-test

src/lint/linter/xhpast/rules/tests/ArcanistPHPCloseTagXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/php-close-tag/php-close-tag-inline-html-good.lint-test

src/lint/linter/xhpast/rules/tests/php-close-tag/php-close-tag.lint-test

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/tests/data/addline.expect

src/lint/renderer/tests/data/addline.txt

src/lint/renderer/tests/data/addlinesuffix.expect

src/lint/renderer/tests/data/addlinesuffix.txt

src/lint/renderer/tests/data/caret.expect

src/lint/renderer/tests/data/caret.txt

src/lint/renderer/tests/data/extrawhitespace.expect

src/lint/renderer/tests/data/extrawhitespace.txt

src/lint/renderer/tests/data/inline.expect

src/lint/renderer/tests/data/inline.txt

src/lint/renderer/tests/data/midline.expect

src/lint/renderer/tests/data/midline.txt

src/lint/renderer/tests/data/newline.expect

src/lint/renderer/tests/data/newline.txt

src/lint/renderer/tests/data/original.expect

src/lint/renderer/tests/data/original.txt

src/lint/renderer/tests/data/overlap.expect

src/lint/renderer/tests/data/overlap.txt

src/lint/renderer/tests/data/remline.expect

src/lint/renderer/tests/data/remline.txt

src/lint/renderer/tests/data/simple.expect

src/lint/renderer/tests/data/simple.txt

src/lint/renderer/tests/data/xml.expect

src/lint/renderer/tests/data/xml.txt

src/unit/parser/tests/XUnitTestResultParserTestCase.php