Allow "arc upload" to work correctly if it can not hash content
ClosedPublic
Actions

Authored by epriestley on Apr 4 2017, 10:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 8:46 AM

	Unknown Object (File)
	Sun, Nov 3, 8:46 AM

	Unknown Object (File)
	Sun, Nov 3, 8:46 AM

	Unknown Object (File)
	Sat, Nov 2, 1:58 AM

	Unknown Object (File)
	Wed, Oct 23, 10:59 PM

	Unknown Object (File)
	Oct 18 2024, 5:36 PM

	Unknown Object (File)
	Sep 6 2024, 6:25 AM

	Unknown Object (File)
	Sep 5 2024, 11:47 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12464: Move away from SHA1 in Files

Commits

rARCc4e84550fcd3: Allow "arc upload" to work correctly if it can not hash content

Summary

Ref T12464. This is similar to D17619 and prepares us to move to SHA256 in the client.

Note that it's fine if arc and Phabricator disagree about hashing algorithms. We don't really trust the client anyway, so if things are mismatched clients will just end up transferring a bit more data instead of getting to cheat when Phabricator already has copies of data.

Test Plan

Ran arc upload, got a clean upload.