Page MenuHomePhabricator

Allow "arc upload" to work correctly if it can not hash content
ClosedPublic

Authored by epriestley on Apr 4 2017, 10:48 PM.
Tags
None
Referenced Files
F12825461: D17621.id.diff
Thu, Mar 28, 8:56 AM
Unknown Object (File)
Fri, Mar 22, 8:58 AM
Unknown Object (File)
Feb 11 2024, 12:29 AM
Unknown Object (File)
Jan 28 2024, 3:36 AM
Unknown Object (File)
Jan 22 2024, 9:55 PM
Unknown Object (File)
Dec 27 2023, 9:34 PM
Unknown Object (File)
Dec 4 2023, 5:25 PM
Unknown Object (File)
Nov 30 2023, 4:39 AM
Subscribers
None

Details

Summary

Ref T12464. This is similar to D17619 and prepares us to move to SHA256 in the client.

Note that it's fine if arc and Phabricator disagree about hashing algorithms. We don't really trust the client anyway, so if things are mismatched clients will just end up transferring a bit more data instead of getting to cheat when Phabricator already has copies of data.

Test Plan

Ran arc upload, got a clean upload.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 4 2017, 10:57 PM
This revision was automatically updated to reflect the committed changes.