Page MenuHomePhabricator
Differential D18511

Restore the caret pointer ("^") for lint lines which only have a character offset
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 7:38 PM.
Tags
None
Referenced Files
F19058451: D18511.id.diff
Sat, Nov 29, 2:04 AM
F18867274: D18511.id.diff
Mon, Nov 3, 10:47 PM
F18847529: D18511.diff
Oct 30 2025, 1:02 AM
F18788069: D18511.diff
Oct 15 2025, 2:41 AM
F18723851: D18511.id44465.diff
Sep 30 2025, 2:15 AM
F18090641: D18511.id44465.diff
Aug 6 2025, 4:34 PM
F18088866: D18511.id44460.diff
Aug 6 2025, 9:54 AM
F18052498: D18511.id.diff
Aug 4 2025, 2:43 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC213ed3ff15d7: Restore the caret pointer ("^") for lint lines which only have a character…
Summary

Ref T9846. This was dropped when I refactored how things are rendered; restore it.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
11 lines
__tests__/
7 lines
data/
11 lines
4 lines

Diff 44465

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/caret.expect

Loading...
View Options

src/lint/renderer/__tests__/data/caret.txt

Loading...
Phabricator · Built by Phacility