Page MenuHomePhabricator
Differential D18511

Restore the caret pointer ("^") for lint lines which only have a character offset
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:33 PM
Unknown Object (File)
Wed, Apr 24, 11:49 PM
Unknown Object (File)
Thu, Apr 11, 8:03 AM
Unknown Object (File)
Mar 28 2024, 2:21 AM
Unknown Object (File)
Mar 15 2024, 8:46 AM
Unknown Object (File)
Feb 24 2024, 1:35 PM
Unknown Object (File)
Feb 24 2024, 12:40 PM
Unknown Object (File)
Feb 14 2024, 7:01 AM
View All 63 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC213ed3ff15d7: Restore the caret pointer ("^") for lint lines which only have a character…
Summary

Ref T9846. This was dropped when I refactored how things are rendered; restore it.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
11 lines
__tests__/
7 lines
data/
11 lines
4 lines

Diff 44465

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/caret.expect

Loading...
View Options

src/lint/renderer/__tests__/data/caret.txt

Loading...
Phabricator · Built by Phacility