Page MenuHomePhabricator
Differential D18511

Restore the caret pointer ("^") for lint lines which only have a character offset
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 12:57 AM
Unknown Object (File)
Thu, Nov 14, 11:11 PM
Unknown Object (File)
Tue, Nov 12, 6:56 AM
Unknown Object (File)
Mon, Nov 11, 8:11 AM
Unknown Object (File)
Sat, Nov 9, 2:34 PM
Unknown Object (File)
Sat, Nov 9, 2:34 PM
Unknown Object (File)
Sat, Nov 9, 2:33 PM
Unknown Object (File)
Wed, Nov 6, 5:04 PM
View All 99 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC213ed3ff15d7: Restore the caret pointer ("^") for lint lines which only have a character…
Summary

Ref T9846. This was dropped when I refactored how things are rendered; restore it.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
11 lines
__tests__/
7 lines
data/
11 lines
4 lines

Diff 44465

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/caret.expect

Loading...
View Options

src/lint/renderer/__tests__/data/caret.txt

Loading...
Phabricator · Built by Phacility