Page MenuHomePhabricator
Differential D18511

Restore the caret pointer ("^") for lint lines which only have a character offset
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 7:38 PM.
Tags
None
Referenced Files
F19799727: D18511.id.diff
Sat, Feb 28, 3:19 AM
F19787594: D18511.diff
Wed, Feb 25, 2:06 PM
F19677675: D18511.id44460.diff
Sun, Feb 8, 2:54 PM
F19641564: D18511.id.diff
Thu, Feb 5, 7:26 PM
F19058451: D18511.id.diff
Nov 29 2025, 2:04 AM
F18867274: D18511.id.diff
Nov 3 2025, 10:47 PM
F18847529: D18511.diff
Oct 30 2025, 1:02 AM
F18788069: D18511.diff
Oct 15 2025, 2:41 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC213ed3ff15d7: Restore the caret pointer ("^") for lint lines which only have a character…
Summary

Ref T9846. This was dropped when I refactored how things are rendered; restore it.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
11 lines
__tests__/
7 lines
data/
11 lines
4 lines

Diff 44465

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/caret.expect

Loading...
View Options

src/lint/renderer/__tests__/data/caret.txt

Loading...
Phabricator · Built by Phacility