Page MenuHomePhabricator
Differential D18511

Restore the caret pointer ("^") for lint lines which only have a character offset
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 7:38 PM.
Tags
None
Referenced Files
F18052498: D18511.id.diff
Mon, Aug 4, 2:43 AM
F18051263: D18511.id44465.diff
Sun, Aug 3, 10:37 PM
F17914930: D18511.diff
Tue, Jul 29, 7:53 PM
F17842678: D18511.id.diff
Sat, Jul 26, 11:59 PM
F17800739: D18511.diff
Fri, Jul 25, 6:53 AM
Unknown Object (File)
Apr 29 2025, 1:17 AM
Unknown Object (File)
Apr 29 2025, 12:26 AM
Unknown Object (File)
Apr 27 2025, 10:27 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC213ed3ff15d7: Restore the caret pointer ("^") for lint lines which only have a character…
Summary

Ref T9846. This was dropped when I refactored how things are rendered; restore it.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
11 lines
__tests__/
7 lines
data/
11 lines
4 lines

Diff 44465

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/caret.expect

Loading...
View Options

src/lint/renderer/__tests__/data/caret.txt

Loading...
Phabricator · Built by Phacility