Consistently use `phutil_console_confirm()`.
ClosedPublic
Actions

Authored by stefren on Jul 6 2017, 9:49 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCb9e79d14c143: (stable) Promote 2017 Week 27
rARC165df12046e5: Consistently use `phutil_console_confirm()`.

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

PhutilConsole->confirm() is vestigial as noted in efcd70c, as
PhutilConsole may be deprecated sometime in the future. PhutilConsole
was developed as a tool for T4281 but the feature has been removed
since.

Replace existing occurences of the PhutilConsole->confirm() pattern with
phutil_console_confirm(). There should be no change in functionality
since the two functions are interchangeable.

Test Plan

Manually tested by running bin/arc lint, bin/arc diff --preview, bin/arc land --preview.

Diff Detail

Repository

rARC Arcanist

Branch

up-master (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17632
Build 23668: arc lint + arc unit

Event Timeline

stefren created this revision.Jul 6 2017, 9:49 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 6 2017, 9:49 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

@stefren should be covered by the #Dropbox corporate CLA.

Thanks! I've added you to Blessed Committers so you should be able to land this directly -- see that project's description for some pointers if you hit issues, or let me know if that doesn't resolve things.

This revision is now accepted and ready to land.Jul 6 2017, 11:11 PM