Page MenuHomePhabricator

Consistently use `phutil_console_confirm()`.
ClosedPublic

Authored by stefren on Jul 6 2017, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 9, 11:14 PM
Unknown Object (File)
Feb 3 2024, 4:19 PM
Unknown Object (File)
Jan 2 2024, 12:29 AM
Unknown Object (File)
Dec 27 2023, 11:37 AM
Unknown Object (File)
Dec 27 2023, 11:37 AM
Unknown Object (File)
Dec 21 2023, 7:59 PM
Unknown Object (File)
Dec 21 2023, 7:59 PM
Unknown Object (File)
Dec 21 2023, 7:59 PM
Subscribers

Details

Summary

PhutilConsole->confirm() is vestigial as noted in efcd70c, as
PhutilConsole may be deprecated sometime in the future. PhutilConsole
was developed as a tool for T4281 but the feature has been removed
since.

Replace existing occurences of the PhutilConsole->confirm() pattern with
phutil_console_confirm(). There should be no change in functionality
since the two functions are interchangeable.

Test Plan

Manually tested by running bin/arc lint, bin/arc diff --preview, bin/arc land --preview.

Diff Detail

Repository
rARC Arcanist
Branch
up-master (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17632
Build 23668: arc lint + arc unit

Event Timeline

@stefren should be covered by the #Dropbox corporate CLA.

Thanks! I've added you to Blessed Committers so you should be able to land this directly -- see that project's description for some pointers if you hit issues, or let me know if that doesn't resolve things.

This revision is now accepted and ready to land.Jul 6 2017, 11:11 PM

(I also added you to Community, granting you sweeping janitorial powers.)