Page MenuHomePhabricator
Differential D18538

Fix a prefix/suffix counting issue in Arcanist lint rendering
ClosedPublic
Actions

Authored by epriestley on Sep 5 2017, 6:50 PM.
Tags
None
Referenced Files
F18420564: D18538.id44509.diff
Sat, Aug 30, 4:24 PM
F18418009: D18538.diff
Sat, Aug 30, 12:34 PM
F18245157: D18538.id44510.diff
Thu, Aug 21, 9:06 AM
F18054523: D18538.id44515.diff
Mon, Aug 4, 6:18 AM
F17948813: D18538.id44510.diff
Thu, Jul 31, 10:04 PM
F17941407: D18538.id44509.diff
Jul 31 2025, 5:24 AM
F17939619: D18538.id.diff
Jul 31 2025, 3:14 AM
F17939431: D18538.id44515.diff
Jul 31 2025, 3:07 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC7371277d2065: Fix a prefix/suffix counting issue in Arcanist lint rendering
Summary

Ref T9846. See PHI48. For replacing text in the form "ABC" with "ABBC", the trimmer had a bug.

Test Plan

Added failing tests, fixed 'em.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 5 2017, 6:50 PM
Harbormaster failed remote builds in B18291: Diff 44509!Sep 5 2017, 6:51 PM
epriestley added a comment.Sep 5 2017, 6:53 PM

That build failure might be "legitimate-ish" -- maybe a version difference.

epriestley added a comment.Sep 5 2017, 6:55 PM

PHP 7.0.0 - If string is equal to start characters long, an empty string will be returned. Prior to this version, FALSE was returned in this case.
http://php.net/substr

Thanks, PHP.

epriestley updated this revision to Diff 44510.Sep 5 2017, 6:55 PM
  • Add some casting to force PHP7 behavior?
Harbormaster completed remote builds in B18292: Diff 44510.Sep 5 2017, 6:56 PM
chad accepted this revision.Sep 5 2017, 8:04 PM
This revision is now accepted and ready to land.Sep 5 2017, 8:04 PM
Closed by commit rARC7371277d2065: Fix a prefix/suffix counting issue in Arcanist lint rendering (authored by epriestley). · Explain WhySep 5 2017, 8:09 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D18541: Fix a similar lint rendering issue when trimming identical lines out of patches.Sep 5 2017, 11:53 PM
epriestley mentioned this in rARCcbc785ddce71: Fix a similar lint rendering issue when trimming identical lines out of patches.Sep 6 2017, 12:12 AM

Revision Contents
Changeset List

PathSize
src/
lint/
14 lines
__tests__/
8 lines
renderer/
__tests__/
22 lines
data/
11 lines
4 lines

Diff 44515

View Options

src/lint/ArcanistLintMessage.php

Loading...
View Options

src/lint/__tests__/ArcanistLintMessageTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/midline.expect

Loading...
View Options

src/lint/renderer/__tests__/data/midline.txt

Loading...
Phabricator · Built by Phacility