Page MenuHomePhabricator

Fix two minor issues with "arc download"
ClosedPublic

Authored by epriestley on Apr 28 2017, 12:22 AM.

Details

Summary

Ref T12651. Ran into these during D17799:

  • Use getStatusCode() to put the actual status code into the message.
  • If we fail but wrote an empty file to reserve the filename, clean it up.
Test Plan
  • Faked the error, phlog()'d the exception.
  • Saw sensible exception message.
  • Saw empty file get cleaned up.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 28 2017, 6:43 AM
This revision was automatically updated to reflect the committed changes.