alexmv (Alex Vandiver)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 3 2015, 8:30 AM (133 w, 4 d)
Availability
Available

Recent Activity

Mon, Feb 5

alexmv added a comment to T13053: Plans: Mail Tags and Failover.

Hrrrm...

Mon, Feb 5, 11:37 PM · Must Encrypt Mail, Mail

Wed, Jan 24

alexmv accepted D18920: Don't error when trying to mirror or observe an empty repository.
Wed, Jan 24, 11:49 PM

Jan 24 2018

alexmv added a comment to D18920: Don't error when trying to mirror or observe an empty repository.

Ah! Yes, sorry for not using the right term.

Jan 24 2018, 8:54 PM
alexmv added a comment to D18920: Don't error when trying to mirror or observe an empty repository.

Please commandeer -- I don't have a trivial way to test this at current.

Jan 24 2018, 8:26 PM
alexmv requested review of D18920: Don't error when trying to mirror or observe an empty repository.
Jan 24 2018, 3:25 AM

Jan 6 2018

epriestley awarded D18861: Fix typo in new setting description a Pterodactyl token.
Jan 6 2018, 3:25 PM
alexmv requested review of D18861: Fix typo in new setting description.
Jan 6 2018, 1:15 AM
alexmv added a watcher for Security: alexmv.
Jan 6 2018, 1:02 AM

Jan 4 2018

alexmv added a comment to D18858: Offer to remove untracked files, so they don't crop up again.

This pain may be mostly derived from prior to D18842 and git performance improvements. At that time, delay until the prompt was ~4s, plus the overhead of noticing, pressing ^C, remembering command-line arguments to git clean, and the startup overhead of the arc diff startup again:

$ time arc diff --preview < /dev/null
You have untracked files in this working copy.
Jan 4 2018, 11:15 PM
alexmv added a comment to D18858: Offer to remove untracked files, so they don't crop up again.

The code currently shows:

Untracked changes in working copy:
(To ignore this change, add it to ".git/info/exclude".)
  foo

...so remembering the path to edit isn't hard, as it's right there. The problem is more the immediacy -- it can be several minutes until one is back at a prompt to be able to run the hypothetical arc ignore, at which point we have the same problem we have now.

Jan 4 2018, 10:43 PM
alexmv added a comment to D18858: Offer to remove untracked files, so they don't crop up again.

I think pressing ! accidentally is difficult -- it was chosen that way. We could bulletproof further via making it require typing I swear under penalty of perjury that I absolve arcanist from any and all fault when these files are removed at the prompt, but that might be a bit much.

Jan 4 2018, 10:10 PM
alexmv requested review of D18858: Offer to remove untracked files, so they don't crop up again.
Jan 4 2018, 9:50 PM

Dec 24 2017

alexmv committed rARC9144658e695c: Accelerate working tree operations in git (authored by alexmv).
Accelerate working tree operations in git
Dec 24 2017, 4:12 AM
alexmv closed D18842: Accelerate working tree operations in git.
Dec 24 2017, 4:12 AM
alexmv closed D18842: Accelerate working tree operations in git.
Dec 24 2017, 4:12 AM
alexmv updated the diff for D18842: Accelerate working tree operations in git.
  • Switch to --rev tip
Dec 24 2017, 4:12 AM
alexmv added inline comments to D18842: Accelerate working tree operations in git.
Dec 24 2017, 4:06 AM
alexmv committed rARCf34467914ca0: Add tests for git submodules, based on current behavior (authored by alexmv).
Add tests for git submodules, based on current behavior
Dec 24 2017, 4:01 AM
alexmv closed D18841: Add tests for git submodules, based on current behavior.
Dec 24 2017, 4:01 AM

Dec 23 2017

epriestley awarded D18842: Accelerate working tree operations in git a Hungry Hippo token.
Dec 23 2017, 4:32 PM
alexmv requested review of D18842: Accelerate working tree operations in git.
Dec 23 2017, 1:14 AM
alexmv added a dependent revision for D18841: Add tests for git submodules, based on current behavior: D18842: Accelerate working tree operations in git.
Dec 23 2017, 1:13 AM
alexmv requested review of D18841: Add tests for git submodules, based on current behavior.
Dec 23 2017, 1:12 AM

Dec 12 2017

alexmv committed rARC249f3a80fe77: Default the prompt for "Amend HEAD with these patches" to true (authored by alexmv).
Default the prompt for "Amend HEAD with these patches" to true
Dec 12 2017, 9:43 AM
alexmv closed D18824: Default the prompt for "Amend HEAD with these patches" to true.
Dec 12 2017, 9:43 AM
alexmv requested review of D18824: Default the prompt for "Amend HEAD with these patches" to true.
Dec 12 2017, 1:39 AM

Nov 22 2017

alexmv accepted D18778: Fix inbound mail handling for messages with no HTML body part.

Sorry for the breakage!

Nov 22 2017, 6:46 PM

Nov 16 2017

alexmv committed rPd2cff6a2cf01: Transcode the HTML part of incoming email into UTF-8 as well (authored by alexmv).
Transcode the HTML part of incoming email into UTF-8 as well
Nov 16 2017, 6:08 PM
alexmv closed D18776: Transcode the HTML part of incoming email into UTF-8 as well.
Nov 16 2017, 6:08 PM
alexmv requested review of D18776: Transcode the HTML part of incoming email into UTF-8 as well.
Nov 16 2017, 9:01 AM

Sep 21 2017

alexmv added a project to D18606: Allow setting file descriptors on ExecFutures: Unknown Object (Project).

Cool, sounds like we're pretty much on the same page, then. Basically, I'm supportive of pursuing this but I'd rather do a "high workflow disruption, low cleverness" change than a "tons of cleverness so we don't have to change any behaviors" sort of change. I don't think the current behavior is sacrosanct and we can probably have a much larger impact by disrupting the current workflow a bit (or a lot).

Sep 21 2017, 10:37 PM · Unknown Object (Project)
alexmv committed rARCc804c5026011: Don't show a blank line if there is no user data (authored by alexmv).
Don't show a blank line if there is no user data
Sep 21 2017, 12:54 AM
alexmv closed D18632: Don't show a blank line if there is no user data.
Sep 21 2017, 12:54 AM
alexmv updated the diff for D18632: Don't show a blank line if there is no user data.

Swap to a strlen, instead of using truthiness

Sep 21 2017, 12:44 AM

Sep 20 2017

alexmv created D18632: Don't show a blank line if there is no user data.
Sep 20 2017, 9:35 PM

Sep 15 2017

alexmv added a comment to D18606: Allow setting file descriptors on ExecFutures.

P2074 is the change that builds on this one

Aaah, I misunderstood what you were trying to build here.

Sep 15 2017, 8:39 PM · Unknown Object (Project)

Sep 14 2017

alexmv added a comment to D18606: Allow setting file descriptors on ExecFutures.

In the past, we ran lint and unit in the background while $EDITOR was open for the user to edit their commit message.

Sep 14 2017, 10:18 PM · Unknown Object (Project)
alexmv edited P2074 Masterwork From Distant Lands.
Sep 14 2017, 10:17 PM
alexmv edited P2073 Masterwork From Distant Lands.
Sep 14 2017, 10:13 PM
alexmv added a comment to D18606: Allow setting file descriptors on ExecFutures.

For context, the underlying goal of this change is to allow us to have Future versions of phutil_console_prompt and phutil_console_confirm which can operate while work is proceeding in the background. Our specific use case is to prompt "Unit tests are expected to take xxx seconds; run them locally?" while sneakily starting to run them in the background while the user is considering their answer. We abort the prompt future if the tests complete before we see a response from the user, and abort the test-running Futures if the user responds 'n'.

Sep 14 2017, 9:00 PM · Unknown Object (Project)
alexmv created D18606: Allow setting file descriptors on ExecFutures.
Sep 14 2017, 8:54 PM · Unknown Object (Project)

Sep 13 2017

alexmv added a comment to T12033: Large diffs can still repeatedly fail to insert.

Do you mean "follow up in PHI55"?

Sep 13 2017, 10:40 PM · Diffusion (v3), Unknown Object (Project), Mail, Differential, Bug Report

Aug 11 2017

epriestley awarded D18391: Remove a debugging "echo" that crept in in dccd799b a Burninate token.
Aug 11 2017, 12:19 PM
alexmv created D18391: Remove a debugging "echo" that crept in in dccd799b.
Aug 11 2017, 5:05 AM

Aug 4 2017

alexmv committed rARC5eda40337bb4: Fix missing whitespace in `arc linters --help` message (authored by alexmv).
Fix missing whitespace in `arc linters --help` message
Aug 4 2017, 8:13 PM
alexmv closed D18344: Fix missing whitespace in `arc linters --help` message.
Aug 4 2017, 8:12 PM
epriestley awarded D18344: Fix missing whitespace in `arc linters --help` message a Pterodactyl token.
Aug 4 2017, 8:00 PM
alexmv created D18344: Fix missing whitespace in `arc linters --help` message.
Aug 4 2017, 7:58 PM

Jul 6 2017

alexmv added a comment to D18185: Consistently use `phutil_console_confirm()`..

@stefren should be covered by the #Dropbox corporate CLA.

Jul 6 2017, 10:07 PM

Jul 5 2017

alexmv added a comment to T12792: Consider an option to disable all popup notifications.

We've also had a request for this (disabling the in-application popups) at #dropbox, as a per-user preference.

Jul 5 2017, 11:46 PM · Feature Request, Customer Impact, Notifications

Jul 4 2017

alexmv created D18181: Append the intermediate chain to the "cert" parameter in Aphlict.
Jul 4 2017, 4:57 AM

Jun 28 2017

alexmv added a project to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Project).

#dropbox has also encountered this since upgrading from MySQL 5.5 to MySQL 5.7, and thus an InnoDB FTS backend.

Jun 28 2017, 5:26 AM · Unknown Object (Project), Search

Jun 12 2017

alexmv added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Beautiful. Sorry for not finding that.

Jun 12 2017, 6:16 PM · Unknown Object (Project), Differential, Bug Report
alexmv added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Sorry, just pulling that out. 4d2c7e4d3d5d61e34b7e2af3df0e901d89d29433

Jun 12 2017, 6:15 PM · Unknown Object (Project), Differential, Bug Report
alexmv added a project to T12829: Synchronous accepts for the same project produce a misleading error: Unknown Object (Project).
Jun 12 2017, 6:14 PM · Unknown Object (Project), Differential, Bug Report
alexmv created T12829: Synchronous accepts for the same project produce a misleading error.
Jun 12 2017, 6:14 PM · Unknown Object (Project), Differential, Bug Report

Jun 7 2017

alexmv added a comment to T12809: Pass through MySQL commands via bin/storage.

Noted, OK. We'll proceed by adding our own local ./bin/storage endpoint for it.

Jun 7 2017, 11:20 PM · Unknown Object (Project), Feature Request
alexmv added a comment to T12809: Pass through MySQL commands via bin/storage.

Would you be adverse to accepting a patch that does this?

Jun 7 2017, 10:52 PM · Unknown Object (Project), Feature Request

Jun 2 2017

alexmv closed T12784: Allow color escapes in PhutilConsoleTable rendering as Invalid.

Aha! That works wonderfully. I think this is INVALID, then.

Jun 2 2017, 2:14 AM · libphutil, Feature Request

Jun 1 2017

alexmv added a comment to T12779: File anchor links can load scrolled to the wrong file.

Thanks for the fixes! Most folks are on Chrome at Dropbox, so Safari being subject to the Heisenprod Uncertainty Principle doesn't worry me much.

Jun 1 2017, 9:35 PM · Unknown Object (Project), Differential, Bug Report
alexmv created T12784: Allow color escapes in PhutilConsoleTable rendering.
Jun 1 2017, 3:35 AM · libphutil, Feature Request
alexmv edited P2057 Masterwork From Distant Lands.
Jun 1 2017, 3:35 AM

May 31 2017

alexmv awarded T5523: Make bulk moves easier on Workboards a Like token.
May 31 2017, 6:15 PM · Unknown Object (Project), Workboards

May 30 2017

alexmv added a comment to T12779: File anchor links can load scrolled to the wrong file.

T11997/T12032 look related, but not the same behavior.

May 30 2017, 11:43 PM · Unknown Object (Project), Differential, Bug Report
alexmv added a comment to T12779: File anchor links can load scrolled to the wrong file.

Forgot to specify browser: this is Chrome 58.0.3029.110 (64-bit) on OS X and Linux. Also replicates on Safari 10.1.1 (12603.2.4).

May 30 2017, 11:41 PM · Unknown Object (Project), Differential, Bug Report
alexmv created T12779: File anchor links can load scrolled to the wrong file.
May 30 2017, 11:38 PM · Unknown Object (Project), Differential, Bug Report

May 27 2017

alexmv closed T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error) as Resolved.

Based on two points of anecdata so far, things indeed seem snappier with D17959.

May 27 2017, 4:32 AM · Unknown Object (Project), Workboards

May 26 2017

alexmv created T12765: Autofixes removing lines render incorrectly in `arc lint`.
May 26 2017, 11:20 PM · Lint, Arcanist, Bug Report

May 25 2017

alexmv updated the test plan for D17951: Build and check `arc patch` dependency chain before creating branches.
May 25 2017, 10:44 PM
alexmv updated the diff for D17951: Build and check `arc patch` dependency chain before creating branches.

Remove the equivalent codepath for Mercurial, which removed the
bookmark which we now never create at all. The entire original_branch
code is now unused, and this removed.

May 25 2017, 10:44 PM

May 20 2017

alexmv updated the diff for D17951: Build and check `arc patch` dependency chain before creating branches.

Add some hopefully edifying comments

May 20 2017, 1:53 AM

May 18 2017

alexmv added inline comments to D17951: Build and check `arc patch` dependency chain before creating branches.
May 18 2017, 8:03 PM
alexmv created D17951: Build and check `arc patch` dependency chain before creating branches.
May 18 2017, 5:27 PM
alexmv committed rARC129d51fa0936: If the base commit for `arc patch` does not exist locally, try to fetch it (authored by alexmv).
If the base commit for `arc patch` does not exist locally, try to fetch it
May 18 2017, 5:13 PM
alexmv closed D17949: If the base commit for `arc patch` does not exist locally, try to fetch it.
May 18 2017, 5:13 PM
alexmv added a comment to D17949: If the base commit for `arc patch` does not exist locally, try to fetch it.

My theory for not execPassthru was if it fails, those failures are likely irrelevant to the matter at hand (maybe they have an old, invalid, remote still hanging out), and spewing them to the console is just going to cause confusion.

May 18 2017, 4:58 PM
alexmv created D17949: If the base commit for `arc patch` does not exist locally, try to fetch it.
May 18 2017, 4:33 PM

May 15 2017

alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Understood -- thanks for the clarification. One isn't always aware of how special-case one is. :)

May 15 2017, 4:14 PM · llvm, Restricted Project, Unknown Object (Project), Mail
alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Sorry, that seemed to be in response to "are you working on this?" A user has since provided a patch for the feature, which is the sort of thing which in the past you folks have generally been nice enough to review.

May 15 2017, 2:53 PM · llvm, Restricted Project, Unknown Object (Project), Mail
alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Phacility folks, do you have thoughts about the patch provided by @lyngvi above? Would be it be easier to review if submitted as a Diff?

May 15 2017, 2:45 PM · llvm, Restricted Project, Unknown Object (Project), Mail

May 10 2017

alexmv added a project to T12700: Bring back diff results from the user page: Unknown Object (Project).
May 10 2017, 2:18 AM · Unknown Object (Project), Feature Request
alexmv created T12700: Bring back diff results from the user page.
May 10 2017, 2:18 AM · Unknown Object (Project), Feature Request

May 6 2017

alexmv created T12682: `storage --dry-run` actually looks rather wet when applying patches.
May 6 2017, 2:15 AM · Bug Report

Apr 20 2017

alexmv committed rARC146693307f60: Make exception reporting from `arc` be in red (authored by alexmv).
Make exception reporting from `arc` be in red
Apr 20 2017, 10:20 PM
alexmv closed D17748: Make exception reporting from `arc` be in red by committing rARC146693307f60: Make exception reporting from `arc` be in red.
Apr 20 2017, 10:20 PM
alexmv created D17748: Make exception reporting from `arc` be in red.
Apr 20 2017, 9:55 PM

Apr 14 2017

alexmv closed T12553: Very dense kerning around pipe characters in revision|task titles as Invalid.

Good to know. Thanks!

Apr 14 2017, 1:52 AM · Unknown Object (Project), Bug Report
alexmv added a project to T12553: Very dense kerning around pipe characters in revision|task titles: Unknown Object (Project).

We're running 216f6be11ece53cb1daafc8fff636dbdb0d7ef3d, not the SHA given above.

Apr 14 2017, 1:45 AM · Unknown Object (Project), Bug Report

Apr 4 2017

alexmv created T12505: Ownership rules whose owning package is a milestone fail to show as accepted.
Apr 4 2017, 9:44 PM · Unknown Object (Project), Projects, Owners, Bug Report

Mar 24 2017

alexmv added a comment to T12449: Cannot set access control for creating new Maniphest forms.

Enabling that form seems to have done the trick -- thanks! Since it got renamed at some point from "Create form," its existence was almost certainly confusing to some previous admin, which is what got us into this.

Mar 24 2017, 10:46 PM · Bug Report
alexmv added a comment to T12449: Cannot set access control for creating new Maniphest forms.

I do now see that, but I'm unclear how to use its form to configure the form to configure the form to configure the form from.

Mar 24 2017, 9:34 PM · Bug Report
alexmv created T12449: Cannot set access control for creating new Maniphest forms.
Mar 24 2017, 9:22 PM · Bug Report
alexmv awarded T12118: Differential email does not contain reviewers/subscribers information anymore a Like token.
Mar 24 2017, 12:08 AM · Restricted Project, Differential, Bug Report

Mar 23 2017

alexmv created T12443: Applying fulltext limits first causes missing results.
Mar 23 2017, 1:31 AM · Restricted Project, Search, Bug Report

Mar 16 2017

alexmv added a comment to D17507: Ignore "Auditors: author" when inferring auditors from commit messages.

Oh -- it avoids foreach (null as ...) for commits with no "Auditors" field, which emits a warning since foreach (...) wants an array.

Mar 16 2017, 8:37 PM
alexmv added inline comments to D17507: Ignore "Auditors: author" when inferring auditors from commit messages.
Mar 16 2017, 8:03 PM
alexmv created T12406: Importing commits which name themselves as the auditor can cause stuck tasks.
Mar 16 2017, 4:03 AM · Bug Report

Mar 6 2017

alexmv updated the task description for T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.
Mar 6 2017, 7:23 PM · Installing & Upgrading, Differential
alexmv added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

The table in the description references a getConduitFieldKey method – which I can't find reference to ever existing in the source. Was that supposed to be getFieldKeyForConduit?

Mar 6 2017, 7:15 AM · Installing & Upgrading, Differential

Feb 16 2017

alexmv committed rPHU863226f4e56c: Prevent backtracking on long JSON strings with escape codes (authored by alexmv).
Prevent backtracking on long JSON strings with escape codes
Feb 16 2017, 10:43 PM