alexmv (Alex Vandiver)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 3 2015, 8:30 AM (123 w, 12 h)
Availability
Available

Recent Activity

Wed, Nov 22

alexmv accepted D18778: Fix inbound mail handling for messages with no HTML body part.

Sorry for the breakage!

Wed, Nov 22, 6:46 PM

Thu, Nov 16

alexmv committed rPd2cff6a2cf01: Transcode the HTML part of incoming email into UTF-8 as well (authored by alexmv).
Transcode the HTML part of incoming email into UTF-8 as well
Thu, Nov 16, 6:08 PM
alexmv closed D18776: Transcode the HTML part of incoming email into UTF-8 as well.
Thu, Nov 16, 6:08 PM
alexmv requested review of D18776: Transcode the HTML part of incoming email into UTF-8 as well.
Thu, Nov 16, 9:01 AM

Sep 21 2017

alexmv added a project to D18606: Allow setting file descriptors on ExecFutures: Unknown Object (Project).

Cool, sounds like we're pretty much on the same page, then. Basically, I'm supportive of pursuing this but I'd rather do a "high workflow disruption, low cleverness" change than a "tons of cleverness so we don't have to change any behaviors" sort of change. I don't think the current behavior is sacrosanct and we can probably have a much larger impact by disrupting the current workflow a bit (or a lot).

Sep 21 2017, 10:37 PM · Unknown Object (Project)
alexmv committed rARCc804c5026011: Don't show a blank line if there is no user data (authored by alexmv).
Don't show a blank line if there is no user data
Sep 21 2017, 12:54 AM
alexmv closed D18632: Don't show a blank line if there is no user data.
Sep 21 2017, 12:54 AM
alexmv updated the diff for D18632: Don't show a blank line if there is no user data.

Swap to a strlen, instead of using truthiness

Sep 21 2017, 12:44 AM

Sep 20 2017

alexmv created D18632: Don't show a blank line if there is no user data.
Sep 20 2017, 9:35 PM

Sep 15 2017

alexmv added a comment to D18606: Allow setting file descriptors on ExecFutures.

P2074 is the change that builds on this one

Aaah, I misunderstood what you were trying to build here.

Sep 15 2017, 8:39 PM · Unknown Object (Project)

Sep 14 2017

alexmv added a comment to D18606: Allow setting file descriptors on ExecFutures.

In the past, we ran lint and unit in the background while $EDITOR was open for the user to edit their commit message.

Sep 14 2017, 10:18 PM · Unknown Object (Project)
alexmv edited P2074 Masterwork From Distant Lands.
Sep 14 2017, 10:17 PM
alexmv edited P2073 Masterwork From Distant Lands.
Sep 14 2017, 10:13 PM
alexmv added a comment to D18606: Allow setting file descriptors on ExecFutures.

For context, the underlying goal of this change is to allow us to have Future versions of phutil_console_prompt and phutil_console_confirm which can operate while work is proceeding in the background. Our specific use case is to prompt "Unit tests are expected to take xxx seconds; run them locally?" while sneakily starting to run them in the background while the user is considering their answer. We abort the prompt future if the tests complete before we see a response from the user, and abort the test-running Futures if the user responds 'n'.

Sep 14 2017, 9:00 PM · Unknown Object (Project)
alexmv created D18606: Allow setting file descriptors on ExecFutures.
Sep 14 2017, 8:54 PM · Unknown Object (Project)

Sep 13 2017

alexmv added a comment to T12033: Large diffs can still repeatedly fail to insert.

Do you mean "follow up in PHI55"?

Sep 13 2017, 10:40 PM · Diffusion (v3), Unknown Object (Project), Mail, Differential, Bug Report

Aug 11 2017

epriestley awarded D18391: Remove a debugging "echo" that crept in in dccd799b a Burninate token.
Aug 11 2017, 12:19 PM
alexmv created D18391: Remove a debugging "echo" that crept in in dccd799b.
Aug 11 2017, 5:05 AM

Aug 4 2017

alexmv committed rARC5eda40337bb4: Fix missing whitespace in `arc linters --help` message (authored by alexmv).
Fix missing whitespace in `arc linters --help` message
Aug 4 2017, 8:13 PM
alexmv closed D18344: Fix missing whitespace in `arc linters --help` message.
Aug 4 2017, 8:12 PM
epriestley awarded D18344: Fix missing whitespace in `arc linters --help` message a Pterodactyl token.
Aug 4 2017, 8:00 PM
alexmv created D18344: Fix missing whitespace in `arc linters --help` message.
Aug 4 2017, 7:58 PM

Jul 6 2017

alexmv added a comment to D18185: Consistently use `phutil_console_confirm()`..

@stefren should be covered by the #Dropbox corporate CLA.

Jul 6 2017, 10:07 PM

Jul 5 2017

alexmv added a comment to T12792: Consider an option to disable all popup notifications.

We've also had a request for this (disabling the in-application popups) at #dropbox, as a per-user preference.

Jul 5 2017, 11:46 PM · Feature Request, Customer Impact, Notifications

Jul 4 2017

alexmv created D18181: Append the intermediate chain to the "cert" parameter in Aphlict.
Jul 4 2017, 4:57 AM

Jun 28 2017

alexmv added a project to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Project).

#dropbox has also encountered this since upgrading from MySQL 5.5 to MySQL 5.7, and thus an InnoDB FTS backend.

Jun 28 2017, 5:26 AM · Unknown Object (Project), Search

Jun 12 2017

alexmv added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Beautiful. Sorry for not finding that.

Jun 12 2017, 6:16 PM · Unknown Object (Project), Differential, Bug Report
alexmv added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Sorry, just pulling that out. 4d2c7e4d3d5d61e34b7e2af3df0e901d89d29433

Jun 12 2017, 6:15 PM · Unknown Object (Project), Differential, Bug Report
alexmv added a project to T12829: Synchronous accepts for the same project produce a misleading error: Unknown Object (Project).
Jun 12 2017, 6:14 PM · Unknown Object (Project), Differential, Bug Report
alexmv created T12829: Synchronous accepts for the same project produce a misleading error.
Jun 12 2017, 6:14 PM · Unknown Object (Project), Differential, Bug Report

Jun 7 2017

alexmv added a comment to T12809: Pass through MySQL commands via bin/storage.

Noted, OK. We'll proceed by adding our own local ./bin/storage endpoint for it.

Jun 7 2017, 11:20 PM · Unknown Object (Project), Feature Request
alexmv added a comment to T12809: Pass through MySQL commands via bin/storage.

Would you be adverse to accepting a patch that does this?

Jun 7 2017, 10:52 PM · Unknown Object (Project), Feature Request

Jun 2 2017

alexmv closed T12784: Allow color escapes in PhutilConsoleTable rendering as Invalid.

Aha! That works wonderfully. I think this is INVALID, then.

Jun 2 2017, 2:14 AM · libphutil, Feature Request

Jun 1 2017

alexmv added a comment to T12779: File anchor links can load scrolled to the wrong file.

Thanks for the fixes! Most folks are on Chrome at Dropbox, so Safari being subject to the Heisenprod Uncertainty Principle doesn't worry me much.

Jun 1 2017, 9:35 PM · Unknown Object (Project), Differential, Bug Report
alexmv created T12784: Allow color escapes in PhutilConsoleTable rendering.
Jun 1 2017, 3:35 AM · libphutil, Feature Request
alexmv edited P2057 Masterwork From Distant Lands.
Jun 1 2017, 3:35 AM

May 31 2017

alexmv awarded T5523: Make bulk moves easier on Workboards a Like token.
May 31 2017, 6:15 PM · Unknown Object (Project), Workboards

May 30 2017

alexmv added a comment to T12779: File anchor links can load scrolled to the wrong file.

T11997/T12032 look related, but not the same behavior.

May 30 2017, 11:43 PM · Unknown Object (Project), Differential, Bug Report
alexmv added a comment to T12779: File anchor links can load scrolled to the wrong file.

Forgot to specify browser: this is Chrome 58.0.3029.110 (64-bit) on OS X and Linux. Also replicates on Safari 10.1.1 (12603.2.4).

May 30 2017, 11:41 PM · Unknown Object (Project), Differential, Bug Report
alexmv created T12779: File anchor links can load scrolled to the wrong file.
May 30 2017, 11:38 PM · Unknown Object (Project), Differential, Bug Report

May 27 2017

alexmv closed T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error) as Resolved.

Based on two points of anecdata so far, things indeed seem snappier with D17959.

May 27 2017, 4:32 AM · Unknown Object (Project), Workboards

May 26 2017

alexmv created T12765: Autofixes removing lines render incorrectly in `arc lint`.
May 26 2017, 11:20 PM · Lint, Arcanist, Bug Report

May 25 2017

alexmv updated the test plan for D17951: Build and check `arc patch` dependency chain before creating branches.
May 25 2017, 10:44 PM
alexmv updated the diff for D17951: Build and check `arc patch` dependency chain before creating branches.

Remove the equivalent codepath for Mercurial, which removed the
bookmark which we now never create at all. The entire original_branch
code is now unused, and this removed.

May 25 2017, 10:44 PM

May 20 2017

alexmv updated the diff for D17951: Build and check `arc patch` dependency chain before creating branches.

Add some hopefully edifying comments

May 20 2017, 1:53 AM

May 18 2017

alexmv added inline comments to D17951: Build and check `arc patch` dependency chain before creating branches.
May 18 2017, 8:03 PM
alexmv created D17951: Build and check `arc patch` dependency chain before creating branches.
May 18 2017, 5:27 PM
alexmv committed rARC129d51fa0936: If the base commit for `arc patch` does not exist locally, try to fetch it (authored by alexmv).
If the base commit for `arc patch` does not exist locally, try to fetch it
May 18 2017, 5:13 PM
alexmv closed D17949: If the base commit for `arc patch` does not exist locally, try to fetch it.
May 18 2017, 5:13 PM
alexmv added a comment to D17949: If the base commit for `arc patch` does not exist locally, try to fetch it.

My theory for not execPassthru was if it fails, those failures are likely irrelevant to the matter at hand (maybe they have an old, invalid, remote still hanging out), and spewing them to the console is just going to cause confusion.

May 18 2017, 4:58 PM
alexmv created D17949: If the base commit for `arc patch` does not exist locally, try to fetch it.
May 18 2017, 4:33 PM

May 15 2017

alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Understood -- thanks for the clarification. One isn't always aware of how special-case one is. :)

May 15 2017, 4:14 PM · llvm, Restricted Project, Unknown Object (Project), Mail
alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Sorry, that seemed to be in response to "are you working on this?" A user has since provided a patch for the feature, which is the sort of thing which in the past you folks have generally been nice enough to review.

May 15 2017, 2:53 PM · llvm, Restricted Project, Unknown Object (Project), Mail
alexmv added a comment to T7477: Handle inbound email with phabricator address in the CC.

Phacility folks, do you have thoughts about the patch provided by @lyngvi above? Would be it be easier to review if submitted as a Diff?

May 15 2017, 2:45 PM · llvm, Restricted Project, Unknown Object (Project), Mail

May 10 2017

alexmv added a project to T12700: Bring back diff results from the user page: Unknown Object (Project).
May 10 2017, 2:18 AM · Unknown Object (Project), Feature Request
alexmv created T12700: Bring back diff results from the user page.
May 10 2017, 2:18 AM · Unknown Object (Project), Feature Request

May 6 2017

alexmv created T12682: `storage --dry-run` actually looks rather wet when applying patches.
May 6 2017, 2:15 AM · Bug Report

Apr 20 2017

alexmv committed rARC146693307f60: Make exception reporting from `arc` be in red (authored by alexmv).
Make exception reporting from `arc` be in red
Apr 20 2017, 10:20 PM
alexmv closed D17748: Make exception reporting from `arc` be in red by committing rARC146693307f60: Make exception reporting from `arc` be in red.
Apr 20 2017, 10:20 PM
alexmv created D17748: Make exception reporting from `arc` be in red.
Apr 20 2017, 9:55 PM

Apr 14 2017

alexmv closed T12553: Very dense kerning around pipe characters in revision|task titles as Invalid.

Good to know. Thanks!

Apr 14 2017, 1:52 AM · Unknown Object (Project), Bug Report
alexmv added a project to T12553: Very dense kerning around pipe characters in revision|task titles: Unknown Object (Project).

We're running 216f6be11ece53cb1daafc8fff636dbdb0d7ef3d, not the SHA given above.

Apr 14 2017, 1:45 AM · Unknown Object (Project), Bug Report

Apr 4 2017

alexmv created T12505: Ownership rules whose owning package is a milestone fail to show as accepted.
Apr 4 2017, 9:44 PM · Unknown Object (Project), Projects, Owners, Bug Report

Mar 24 2017

alexmv added a comment to T12449: Cannot set access control for creating new Maniphest forms.

Enabling that form seems to have done the trick -- thanks! Since it got renamed at some point from "Create form," its existence was almost certainly confusing to some previous admin, which is what got us into this.

Mar 24 2017, 10:46 PM · Bug Report
alexmv added a comment to T12449: Cannot set access control for creating new Maniphest forms.

I do now see that, but I'm unclear how to use its form to configure the form to configure the form to configure the form from.

Mar 24 2017, 9:34 PM · Bug Report
alexmv created T12449: Cannot set access control for creating new Maniphest forms.
Mar 24 2017, 9:22 PM · Bug Report
alexmv awarded T12118: Differential email does not contain reviewers/subscribers information anymore a Like token.
Mar 24 2017, 12:08 AM · Unknown Object (Project), Differential, Bug Report

Mar 23 2017

alexmv created T12443: Applying fulltext limits first causes missing results.
Mar 23 2017, 1:31 AM · Unknown Object (Project), Search, Bug Report

Mar 16 2017

alexmv added a comment to D17507: Ignore "Auditors: author" when inferring auditors from commit messages.

Oh -- it avoids foreach (null as ...) for commits with no "Auditors" field, which emits a warning since foreach (...) wants an array.

Mar 16 2017, 8:37 PM
alexmv added inline comments to D17507: Ignore "Auditors: author" when inferring auditors from commit messages.
Mar 16 2017, 8:03 PM
alexmv created T12406: Importing commits which name themselves as the auditor can cause stuck tasks.
Mar 16 2017, 4:03 AM · Bug Report

Mar 6 2017

alexmv updated the task description for T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.
Mar 6 2017, 7:23 PM · Installing & Upgrading, Differential
alexmv added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

The table in the description references a getConduitFieldKey method – which I can't find reference to ever existing in the source. Was that supposed to be getFieldKeyForConduit?

Mar 6 2017, 7:15 AM · Installing & Upgrading, Differential

Feb 16 2017

alexmv committed rPHU863226f4e56c: Prevent backtracking on long JSON strings with escape codes (authored by alexmv).
Prevent backtracking on long JSON strings with escape codes
Feb 16 2017, 10:43 PM
alexmv closed D17363: Prevent backtracking on long JSON strings with escape codes by committing rPHU863226f4e56c: Prevent backtracking on long JSON strings with escape codes.
Feb 16 2017, 10:43 PM
alexmv added a comment to D17363: Prevent backtracking on long JSON strings with escape codes.

Yup, will try to get this upstreamed.

Feb 16 2017, 10:23 PM
alexmv updated the diff for D17363: Prevent backtracking on long JSON strings with escape codes.

Non-backtracking forms of the two repetition characters.

Feb 16 2017, 10:22 PM
alexmv updated the summary of D17363: Prevent backtracking on long JSON strings with escape codes.
Feb 16 2017, 10:21 PM
epriestley awarded D17363: Prevent backtracking on long JSON strings with escape codes a Evil Spooky Haunted Tree token.
Feb 16 2017, 2:30 AM
alexmv created D17363: Prevent backtracking on long JSON strings with escape codes.
Feb 16 2017, 2:15 AM

Feb 14 2017

alexmv closed T10881: git diff parsing fails with --submodule=log as Resolved.
Feb 14 2017, 1:41 AM · Contributor Onboarding, Arcanist, Bug Report
alexmv committed rARCf3037bf216e5: [git] Override `diff.submodule` so `git diff` output is always parseable (authored by alexmv).
[git] Override `diff.submodule` so `git diff` output is always parseable
Feb 14 2017, 1:40 AM
alexmv closed D17327: [git] Override `diff.submodule` so `git diff` output is always parseable.
Feb 14 2017, 1:40 AM

Feb 9 2017

alexmv updated the diff for D17327: [git] Override `diff.submodule` so `git diff` output is always parseable.

Fix typo in comment

Feb 9 2017, 12:32 AM
alexmv updated the test plan for D17327: [git] Override `diff.submodule` so `git diff` output is always parseable.
Feb 9 2017, 12:26 AM
alexmv created D17327: [git] Override `diff.submodule` so `git diff` output is always parseable.
Feb 9 2017, 12:25 AM

Jan 17 2017

alexmv closed T11713: `utf8_decode` is provided by XML extension, which may not be installed as Resolved.

Fixed by D17188.

Jan 17 2017, 5:54 PM · libphutil, Bug Report

Jan 12 2017

alexmv committed rPHU6cd38ce75fea: Fall back to from utf8_decode to phutil_utf8v for codepoint counting (authored by alexmv).
Fall back to from utf8_decode to phutil_utf8v for codepoint counting
Jan 12 2017, 3:32 PM
alexmv closed D17188: Fall back to from utf8_decode to phutil_utf8v for codepoint counting by committing rPHU6cd38ce75fea: Fall back to from utf8_decode to phutil_utf8v for codepoint counting.
Jan 12 2017, 3:32 PM
alexmv closed D17188: Fall back to from utf8_decode to phutil_utf8v for codepoint counting.
Jan 12 2017, 3:32 PM
alexmv updated the diff for D17188: Fall back to from utf8_decode to phutil_utf8v for codepoint counting.

Rebase and re-run unit tests.

Jan 12 2017, 3:31 PM
alexmv committed rPHUe4b06e06ee78: Stop hardcoding the YACC error message (authored by alexmv).
Stop hardcoding the YACC error message
Jan 12 2017, 3:30 PM
alexmv closed D17189: Stop hardcoding the YACC error message.
Jan 12 2017, 3:30 PM
alexmv created D17189: Stop hardcoding the YACC error message.
Jan 12 2017, 3:26 PM
alexmv added a comment to D17188: Fall back to from utf8_decode to phutil_utf8v for codepoint counting.

I think that's unrelated to this change, and purely based on the yacc version in the environment. Mind if I split that out into a separate diff?

Jan 12 2017, 3:12 PM
alexmv created D17188: Fall back to from utf8_decode to phutil_utf8v for codepoint counting.
Jan 12 2017, 3:02 PM

Dec 21 2016

alexmv committed rP972604e0e59c: Set `TERM` to prevent `No entry for terminal type "unknown"` messages during… (authored by alexmv).
Set `TERM` to prevent `No entry for terminal type "unknown"` messages during…
Dec 21 2016, 11:17 PM
alexmv closed D17100: Set `TERM` to prevent `No entry for terminal type "unknown"` messages during fetch.
Dec 21 2016, 11:17 PM
alexmv created D17100: Set `TERM` to prevent `No entry for terminal type "unknown"` messages during fetch.
Dec 21 2016, 10:58 PM
alexmv added a comment to T12033: Large diffs can still repeatedly fail to insert.

metamta.email-body-limit is unset.

Dec 21 2016, 10:17 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report