Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
F19507562: D17147.id41238.diff
Fri, Jan 9, 9:39 PM
F19507561: D17147.id41236.diff
Fri, Jan 9, 9:39 PM
F19507560: D17147.id.diff
Fri, Jan 9, 9:39 PM
F19396013: D17147.diff
Sat, Dec 27, 9:47 AM
F19275647: D17147.id41236.diff
Tue, Dec 23, 12:41 AM
F19214127: D17147.id41238.diff
Wed, Dec 17, 4:42 AM
F18834795: D17147.id41238.diff
Oct 26 2025, 10:52 AM
F18812171: D17147.id.diff
Oct 20 2025, 7:28 AM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable