Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
F13176679: D17147.diff
Wed, May 8, 4:18 PM
Unknown Object (File)
Sun, May 5, 5:19 PM
Unknown Object (File)
Fri, Apr 19, 6:01 PM
Unknown Object (File)
Fri, Apr 19, 11:45 AM
Unknown Object (File)
Apr 15 2024, 6:28 PM
Unknown Object (File)
Apr 13 2024, 5:01 AM
Unknown Object (File)
Apr 3 2024, 12:41 AM
Unknown Object (File)
Mar 28 2024, 1:02 PM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable