Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
F18181116: D17147.id41238.diff
Sat, Aug 16, 7:35 AM
F18109955: D17147.id41238.diff
Mon, Aug 11, 3:27 PM
F18109954: D17147.id41236.diff
Mon, Aug 11, 3:27 PM
F18109952: D17147.id.diff
Mon, Aug 11, 3:27 PM
F18104699: D17147.diff
Sun, Aug 10, 1:39 PM
F18094280: D17147.id.diff
Thu, Aug 7, 10:03 PM
F17975642: D17147.id.diff
Fri, Aug 1, 5:06 PM
F17952068: D17147.diff
Fri, Aug 1, 1:55 AM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable