Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 10, 12:53 PM
Unknown Object (File)
Fri, Apr 25, 3:27 PM
Unknown Object (File)
Fri, Apr 25, 12:18 AM
Unknown Object (File)
Apr 7 2025, 4:48 AM
Unknown Object (File)
Apr 5 2025, 6:56 PM
Unknown Object (File)
Mar 29 2025, 7:19 PM
Unknown Object (File)
Mar 24 2025, 5:09 PM
Unknown Object (File)
Mar 24 2025, 2:15 AM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable