Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
F18834795: D17147.id41238.diff
Sun, Oct 26, 10:52 AM
F18812171: D17147.id.diff
Mon, Oct 20, 7:28 AM
F18740371: D17147.id41236.diff
Oct 2 2025, 2:23 AM
F18701492: D17147.id41238.diff
Sep 27 2025, 7:25 PM
F18678211: D17147.id.diff
Sep 25 2025, 10:27 PM
F18657241: D17147.diff
Sep 23 2025, 1:01 AM
F18653305: D17147.diff
Sep 21 2025, 12:12 PM
F18577524: D17147.diff
Sep 10 2025, 7:22 PM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable