Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jul 3 2026, 2:32 AM
Unknown Object (File)
Jun 21 2026, 9:58 AM
Unknown Object (File)
May 29 2026, 9:03 PM
Unknown Object (File)
Apr 21 2026, 11:29 AM
Unknown Object (File)
Apr 17 2026, 3:32 AM
Unknown Object (File)
Apr 7 2026, 8:50 AM
Unknown Object (File)
Mar 12 2026, 1:46 PM
Unknown Object (File)
Mar 2 2026, 11:50 PM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable