Page MenuHomePhabricator

Fix a bad interaction between "arc diff --reviewers" and "the first line of a message is always a title"
ClosedPublic

Authored by epriestley on Jan 5 2017, 10:00 PM.
Tags
None
Referenced Files
F19946921: D17147.id.diff
Fri, Apr 17, 3:32 AM
F19924958: D17147.diff
Tue, Apr 7, 8:50 AM
F19846659: D17147.id.diff
Mar 12 2026, 1:46 PM
F19805817: D17147.id41236.diff
Mar 2 2026, 11:50 PM
F19517771: D17147.id.diff
Jan 15 2026, 3:14 PM
F19516454: D17147.diff
Jan 15 2026, 12:15 AM
F19507562: D17147.id41238.diff
Jan 9 2026, 9:39 PM
F19507561: D17147.id41236.diff
Jan 9 2026, 9:39 PM
Subscribers
None

Details

Summary

Fixes T12069. We implement "arc diff --reviewers" (and "--cc") by parsing a faux message with "Reviewers: ...".

After D17122, the first line of the message is always interpreted as a title, so the text ends up in the message body.

Instead, use a placeholder title so these fields are never initial fields.

Test Plan

Ran arc diff --reviewers dog, got only one "Reviewers" field.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable