Diffusion Arcanist 3b6b523c2b23

Fix errors found by PHPStan
3b6b523c2b23
Actions

Authored by vrana on Feb 18 2017, 9:24 AM.

Description

Fix errors found by PHPStan

Test Plan: None.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D17376

Details

Committed

vrana

Feb 18 2017, 9:24 AM

Pushed

industry

Feb 18 2017, 9:24 AM

Reviewer

Blessed Reviewers

Differential Revision

D17376: Fix errors found by PHPStan

Parents

rARCd0353d238113: Fix errors found by PHPStan

Branches

Unknown

Tags

Unknown

Build Status

Buildable 15699
Build 20737: Run Core Tests

Event Timeline

vrana committed rARC3b6b523c2b23: Fix errors found by PHPStan (authored by vrana).Feb 18 2017, 9:24 AM

Herald added an auditor: • adampetrovic. · View Herald TranscriptFeb 18 2017, 9:24 AM

This commit now requires audit.Feb 18 2017, 9:24 AM

Harbormaster completed building B15699: rARC3b6b523c2b23: Fix errors found by PHPStan.Feb 18 2017, 9:24 AM

Mnkras mentioned this in T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.Feb 19 2017, 6:08 PM

OCram mentioned this in T12294: File Extension Changes while Downloading.Feb 20 2017, 11:13 AM

Mnkras mentioned this in T12303: Print View in Phriction shows Persistent Chat.Feb 21 2017, 8:26 PM

willplatts mentioned this in T12304: Herald fails to add auditors if the author is an auditor.Feb 22 2017, 10:51 AM

willplatts mentioned this in T12305: Persistent chat overlaps various "next" buttons.Feb 22 2017, 10:59 AM

epriestley mentioned this in 2017 Week 8 (Very Late February).Feb 25 2017, 2:17 AM

Mnkras mentioned this in T12317: PhabricatorTriggerDaemon shows as "Waiting" but there are no errors.Feb 26 2017, 3:35 AM

ivo mentioned this in T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.Feb 27 2017, 5:53 PM

borna.emami mentioned this in T12330: Subprojects link not grayed out in dark background of project workboards..Feb 28 2017, 6:42 AM

eliaspro mentioned this in T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'.".Mar 3 2017, 9:08 PM

tomheng mentioned this in T12351: diviner generate book failed.Mar 4 2017, 7:25 AM

epriestley mentioned this in 2017 Week 9 (Early March).Mar 5 2017, 12:18 AM

friesenschrauber mentioned this in T12356: Calendar Notification is not respecting my Time Zone Settings.Mar 6 2017, 6:58 AM

lambdafu mentioned this in T12359: Registration does not accept valid email addresses.Mar 6 2017, 8:17 PM

eliaspro mentioned this in T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.Mar 7 2017, 11:35 AM

eliaspro mentioned this in T12366: Long Project names outgrow dropdown widget.Mar 7 2017, 7:12 PM

eliaspro mentioned this in T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.Mar 7 2017, 8:00 PM

rlex mentioned this in T12377: S3 cannot migrate / upload files.Mar 9 2017, 1:27 PM

epriestley mentioned this in 2017 Week 10 (Mid March).Mar 11 2017, 7:27 PM

MagicInventor mentioned this in T12386: Delete this task.Mar 11 2017, 11:33 PM

eliaspro mentioned this in T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale.Mar 15 2017, 2:08 AM

gd mentioned this in T12409: `./bin/config set --database` does not handle deleted keys.Mar 16 2017, 6:37 PM

epriestley mentioned this in 2017 Week 11 (Late March).Mar 18 2017, 12:21 AM

eliaspro mentioned this in T12416: Repository mirroring fails due to new `git ls-remote` usage.Mar 18 2017, 10:34 PM

Zebradil mentioned this in T12424: Error with new hosted repository.Mar 20 2017, 11:13 PM

boruchy mentioned this in T12437: Phriction Public Visibility requires login.Mar 22 2017, 2:16 PM

gd mentioned this in T12439: Maniphest comment editing fails with required custom field and edge.Mar 22 2017, 4:10 PM

deathsyn mentioned this in T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation?.Mar 23 2017, 4:41 PM

cspeckmim mentioned this in T12453: Using `arc patch` will leave behind a bookmark when answering 'No' in attempt to apply to current state in Mercurial repository.Mar 27 2017, 1:33 PM

Changes (9)

Path

Size

src/

lint/

ArcanistLintMessage.php

linter/

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

repository/

api/

ArcanistGitAPI.php

ArcanistMercurialAPI.php

ArcanistRepositoryAPI.php

unit/

engine/

XUnitTestEngine.php

workflow/

ArcanistLandWorkflow.php

ArcanistPatchWorkflow.php

ArcanistWorkflow.php

rARC3b6b523c2b23

View Options

src/lint/ArcanistLintMessage.php

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/api/ArcanistMercurialAPI.php

View Options

src/repository/api/ArcanistRepositoryAPI.php

View Options

src/unit/engine/XUnitTestEngine.php

View Options

src/workflow/ArcanistLandWorkflow.php

View Options

src/workflow/ArcanistPatchWorkflow.php

View Options

src/workflow/ArcanistWorkflow.php

Fix errors found by PHPStan3b6b523c2b23Actions

Description

Details

Event Timeline

Changes (9)

rARC3b6b523c2b23

src/lint/ArcanistLintMessage.php

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

src/repository/api/ArcanistGitAPI.php

src/repository/api/ArcanistMercurialAPI.php

src/repository/api/ArcanistRepositoryAPI.php

src/unit/engine/XUnitTestEngine.php

src/workflow/ArcanistLandWorkflow.php

src/workflow/ArcanistPatchWorkflow.php

src/workflow/ArcanistWorkflow.php

Fix errors found by PHPStan
3b6b523c2b23
Actions