Paths

Table of Contentst

Make "arc download" use "file.search" if available
ClosedPublic
Actions

Authored by epriestley on Apr 4 2017, 4:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 1:51 PM

	Unknown Object (File)
	Thu, Nov 21, 2:12 AM

	Unknown Object (File)
	Mon, Nov 18, 7:49 PM

	Unknown Object (File)
	Fri, Nov 15, 11:56 AM

	Unknown Object (File)
	Mon, Nov 11, 2:59 PM

	Unknown Object (File)
	Wed, Nov 6, 11:04 PM

	Unknown Object (File)
	Mon, Nov 4, 12:48 AM

	Unknown Object (File)
	Sat, Oct 26, 11:37 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T8348: `arc download` doesn't support chunked downloads

Commits

rARC82b7cd778a28: Make "arc download" use "file.search" if available

Summary

Fixes T8348. Just use normal HTTP GET to download files if the server is sufficiently modern.

Test Plan

Downloaded various files with --as, --show, large files, small files, old server, new server.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 4 2017, 4:53 PM

Harbormaster completed remote builds in B16285: Diff 42358.Apr 4 2017, 4:53 PM

chad accepted this revision.Apr 4 2017, 8:54 PM

This revision is now accepted and ready to land.Apr 4 2017, 8:54 PM

epriestley mentioned this in T8348: `arc download` doesn't support chunked downloads.Apr 4 2017, 11:14 PM

Closed by commit rARC82b7cd778a28: Make "arc download" use "file.search" if available (authored by epriestley, committed by epriestley). · Explain WhyApr 4 2017, 11:16 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12651: Update `bin/host download` to use the newer API.Apr 27 2017, 4:43 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDownloadWorkflow.php

157 lines

Diff 42378

View Options

src/workflow/ArcanistDownloadWorkflow.php

Make "arc download" use "file.search" if availableClosedPublicActions