Page MenuHomePhabricator

Render lint patches which have newlines in a less misleading way
ClosedPublic

Authored by epriestley on Aug 31 2017, 7:25 PM.
Tags
None
Referenced Files
F15571693: D18510.id44459.diff
Mon, May 5, 9:42 AM
F15554125: D18510.id.diff
Mon, Apr 28, 5:36 AM
F15549467: D18510.id44464.diff
Sun, Apr 27, 5:57 AM
F15547554: D18510.id.diff
Sat, Apr 26, 7:43 PM
F15546098: D18510.diff
Sat, Apr 26, 1:50 PM
F15541104: D18510.diff
Fri, Apr 25, 10:49 AM
F15532385: D18510.id44464.diff
Wed, Apr 23, 3:43 PM
F15509756: D18510.diff
Wed, Apr 16, 3:54 PM
Subscribers
None

Details

Summary

Ref T9846. This rewrites the rendering algorithm in a mostly-compatible way and fixes the major issue.

  • Includes test coverage for removing a newline, from T12765.
  • Includes test coverage for mangling an XML tag, from T9846.

This omits two features, which I'll port forward separately:

  • For one-line patches, highlighting the patched section.
  • For zero-line patches, putting a little caret ("^") under the character where the warning occurred.

I'll restore these features in a followup change.

Test Plan

Ran unit tests, linted a few things.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 31 2017, 7:43 PM
This revision was automatically updated to reflect the committed changes.