Page MenuHomePhabricator

Render lint patches which have newlines in a less misleading way
ClosedPublic

Authored by epriestley on Aug 31 2017, 7:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 4:24 PM
Unknown Object (File)
Fri, Dec 20, 7:25 AM
Unknown Object (File)
Fri, Dec 13, 7:42 PM
Unknown Object (File)
Fri, Nov 29, 8:12 AM
Unknown Object (File)
Fri, Nov 29, 1:24 AM
Unknown Object (File)
Thu, Nov 28, 4:14 AM
Unknown Object (File)
Mon, Nov 25, 8:31 AM
Unknown Object (File)
Sun, Nov 24, 12:48 AM
Subscribers
None

Details

Summary

Ref T9846. This rewrites the rendering algorithm in a mostly-compatible way and fixes the major issue.

  • Includes test coverage for removing a newline, from T12765.
  • Includes test coverage for mangling an XML tag, from T9846.

This omits two features, which I'll port forward separately:

  • For one-line patches, highlighting the patched section.
  • For zero-line patches, putting a little caret ("^") under the character where the warning occurred.

I'll restore these features in a followup change.

Test Plan

Ran unit tests, linted a few things.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 31 2017, 7:43 PM
This revision was automatically updated to reflect the committed changes.