Page MenuHomePhabricator

Render lint patches which have newlines in a less misleading way
ClosedPublic

Authored by epriestley on Aug 31 2017, 7:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:26 PM
Unknown Object (File)
Wed, Nov 6, 12:03 AM
Unknown Object (File)
Wed, Nov 6, 12:03 AM
Unknown Object (File)
Wed, Nov 6, 12:03 AM
Unknown Object (File)
Mon, Nov 4, 10:33 AM
Unknown Object (File)
Tue, Oct 29, 9:53 PM
Unknown Object (File)
Oct 19 2024, 12:52 PM
Unknown Object (File)
Oct 12 2024, 11:46 AM
Subscribers
None

Details

Summary

Ref T9846. This rewrites the rendering algorithm in a mostly-compatible way and fixes the major issue.

  • Includes test coverage for removing a newline, from T12765.
  • Includes test coverage for mangling an XML tag, from T9846.

This omits two features, which I'll port forward separately:

  • For one-line patches, highlighting the patched section.
  • For zero-line patches, putting a little caret ("^") under the character where the warning occurred.

I'll restore these features in a followup change.

Test Plan

Ran unit tests, linted a few things.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 31 2017, 7:43 PM
This revision was automatically updated to reflect the committed changes.