Page MenuHomePhabricator
Differential D18631

Correct lint rendering when patching trailing whitespace in files
ClosedPublic
Actions

Authored by epriestley on Sep 20 2017, 7:02 PM.
Tags
None
Referenced Files
F15509673: D18631.id44728.diff
Wed, Apr 16, 3:08 PM
F15496485: D18631.id44730.diff
Sun, Apr 13, 6:56 AM
F15495538: D18631.id.diff
Sun, Apr 13, 4:51 AM
F15494986: D18631.id44729.diff
Sun, Apr 13, 2:16 AM
F15493031: D18631.id.diff
Sat, Apr 12, 8:56 PM
F15489002: D18631.diff
Fri, Apr 11, 5:08 AM
F15469280: D18631.id44729.diff
Fri, Apr 4, 11:28 AM
F15454607: D18631.diff
Sat, Mar 29, 7:19 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rARC19d41faddd13: (stable) Correct lint rendering when patching trailing whitespace in files
rARCb836557b12b3: Correct lint rendering when patching trailing whitespace in files
Summary

Ref PHI48. If a patch removes all of the lines at the end of a file, we can get some array index errors.

Test Plan

Added failing test, made it pass.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 20 2017, 7:02 PM
Harbormaster completed remote builds in B18505: Diff 44728.Sep 20 2017, 7:03 PM
amckinley accepted this revision.Sep 20 2017, 7:04 PM
This revision is now accepted and ready to land.Sep 20 2017, 7:04 PM
epriestley updated this revision to Diff 44729.Sep 20 2017, 7:05 PM
  • Be a little more clever so the test case does not need to have trailing whitespace itself.
  • Also, this made a lint description more concise.
Harbormaster completed remote builds in B18506: Diff 44729.Sep 20 2017, 7:06 PM
Closed by commit rARCb836557b12b3: Correct lint rendering when patching trailing whitespace in files (authored by epriestley). · Explain WhySep 20 2017, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44730

View Options

src/lint/linter/ArcanistTextLinter.php

Loading...
View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/extrawhitespace.expect

Loading...
View Options

src/lint/renderer/__tests__/data/extrawhitespace.txt

Loading...
Phabricator · Built by Phacility