HomePhabricator

Fix a property name collision in ArcanistHgServerChannel

Description

Fix a property name collision in ArcanistHgServerChannel

Summary:
See D2665. Here, channel is the Mercurial wire protocol channel name ("o" = "output", "e" = "error", etc), not the underlying channel from PhutilProxyChannel.

Rename the property so there's no collision.

Test Plan:

$ ../../core/lib/arcanist/scripts/hgdaemon/hgdaemon_client.php . --trace --skip-hello
array(3) {
  [0]=>
  int(0)
  [1]=>
  string(103) "capabilities: getencoding runcommand
encoding: UTF-8
pid: 73263e20cf21273d50f1f66cab6e0f7c74f4864e67f0f"
  [2]=>
  string(0) ""
}

Executed in 30647 us.

Reviewers: vrana, chad

Reviewed By: vrana

Differential Revision: https://secure.phabricator.com/D17366

Details

Provenance
epriestleyAuthored on Feb 16 2017, 1:08 PM
epriestleyPushed on Feb 16 2017, 1:44 PM
Reviewer
vrana
Differential Revision
D17366: Fix a property name collision in ArcanistHgServerChannel
Parents
rARC13596cd10fbe: Add back pht()s and tsprintf()s to arg set-config
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15659
Build 20677: Run Core Tests