Page MenuHomePhabricator

Make exception reporting from `arc` be in red
ClosedPublic

Authored by alexmv on Apr 20 2017, 9:55 PM.
Tags
None
Referenced Files
F18807110: D17748.id42693.diff
Oct 18 2025, 11:12 PM
F18671601: D17748.diff
Sep 25 2025, 4:30 AM
F18657938: D17748.id42691.diff
Sep 23 2025, 4:08 AM
F18620909: D17748.id.diff
Sep 15 2025, 6:35 AM
F18613346: D17748.diff
Sep 14 2025, 11:02 AM
F18594326: D17748.diff
Sep 12 2025, 5:49 PM
F18586658: D17748.diff
Sep 11 2025, 7:20 PM
F18094582: D17748.id.diff
Aug 7 2025, 10:13 PM
Subscribers

Details

Summary

Many other status updates (such as "Builds passed!") show up
in bright background colors, making them more salient than a final
fatal "Exception".

Make exception reporting be just as colorful, so it stands out.

Test Plan

Added an explicit throw new Exception("!!!") and saw it
in red.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

For consistency with other similar color blocks, consider ** %s ** (that is, put spaces around the string so there's more color at either end).

This revision is now accepted and ready to land.Apr 20 2017, 10:11 PM
This revision was automatically updated to reflect the committed changes.