Add basic test coverage for lint console rendering
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 3:40 PM.

Tags

None

Referenced Files

	F15555263: D18508.id.diff
	Mon, Apr 28, 10:34 AM

	F15549668: D18508.diff
	Sun, Apr 27, 7:12 AM

	F15484635: D18508.id44462.diff
	Wed, Apr 9, 7:19 PM

	F15460545: D18508.id44456.diff
	Mar 31 2025, 11:51 PM

	F15452350: D18508.id44456.diff
	Mar 29 2025, 4:05 AM

	F15451981: D18508.id44462.diff
	Mar 29 2025, 12:58 AM

	F15440257: D18508.id.diff
	Mar 26 2025, 11:42 AM

	F15409841: D18508.diff
	Mar 19 2025, 5:40 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T9846: Diff on `arc lint` misleading when the replacement has newlines

Commits

rARCab0d81bca292: Add basic test coverage for lint console rendering

Summary

Ref T9846. The algorithm here is fairly invovled, so lay down some test coverage before breaking it.

Test Plan

Ran tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 31 2017, 3:40 PM

Harbormaster completed remote builds in B18240: Diff 44456.Aug 31 2017, 3:40 PM

chad accepted this revision.Aug 31 2017, 3:49 PM

This revision is now accepted and ready to land.Aug 31 2017, 3:49 PM

Closed by commit rARCab0d81bca292: Add basic test coverage for lint console rendering (authored by epriestley). · Explain WhyAug 31 2017, 8:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

lint/

renderer/

__tests__/

ArcanistConsoleLintRendererTestCase.php

89 lines

data/

8 lines

1 line

10 lines

3 lines

Diff 44462

View Options

src/__phutil_library_map__.php

View Options

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

View Options

src/lint/renderer/tests/data/inline.expect

View Options

src/lint/renderer/tests/data/inline.txt

View Options

src/lint/renderer/tests/data/simple.expect

View Options

src/lint/renderer/tests/data/simple.txt

Add basic test coverage for lint console renderingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44462

src/__phutil_library_map__.php

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/__tests__/data/inline.expect

src/lint/renderer/__tests__/data/inline.txt

src/lint/renderer/__tests__/data/simple.expect

src/lint/renderer/__tests__/data/simple.txt

Add basic test coverage for lint console rendering
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/tests/data/inline.expect

src/lint/renderer/tests/data/inline.txt

src/lint/renderer/tests/data/simple.expect

src/lint/renderer/tests/data/simple.txt