Paths

Table of Contentst

Cheat our way through `arc version` on Windows for the moment
ClosedPublic
Actions

Authored by epriestley on Sep 2 2017, 1:04 AM.

Tags

None

Referenced Files

	F13088895: D18518.diff
	Thu, Apr 25, 1:35 AM

	Unknown Object (File)
	Fri, Apr 19, 6:47 PM

	Unknown Object (File)
	Mon, Apr 15, 10:45 PM

	Unknown Object (File)
	Thu, Apr 11, 9:15 AM

	Unknown Object (File)
	Sat, Apr 6, 2:31 AM

	Unknown Object (File)
	Sat, Mar 30, 5:03 AM

	Unknown Object (File)
	Fri, Mar 29, 4:22 PM

	Unknown Object (File)
	Mar 22 2024, 11:05 AM

View All 99 Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T8291: arc version fails on Windows

Commits

rARCd9cb5b18fbc1: Cheat our way through `arc version` on Windows for the moment

Summary

Fixes T8291. See PHI52. This is papering over the real issue (T8298) but it's a 10-second patch so just improve things slightly for now.

Test Plan

Ran arc version locally; patch confirmed on a Windows system by an affected user.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 2 2017, 1:04 AM

Harbormaster completed remote builds in B18261: Diff 44477.Sep 2 2017, 1:05 AM

chad accepted this revision.Sep 2 2017, 1:05 AM

This revision is now accepted and ready to land.Sep 2 2017, 1:05 AM

Closed by commit rARCd9cb5b18fbc1: Cheat our way through `arc version` on Windows for the moment (authored by epriestley). · Explain WhySep 2 2017, 1:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistVersionWorkflow.php

10 lines

Diff 44478

View Options

src/workflow/ArcanistVersionWorkflow.php

Cheat our way through `arc version` on Windows for the momentClosedPublicActions