Page MenuHomePhabricator
Differential D18541

Fix a similar lint rendering issue when trimming identical lines out of patches
ClosedPublic
Actions

Authored by epriestley on Sep 5 2017, 11:53 PM.
Tags
None
Referenced Files
F18395702: D18541.id44524.diff
Fri, Aug 29, 11:24 AM
F18395058: D18541.id44524.diff
Fri, Aug 29, 10:45 AM
F18382076: D18541.id.diff
Thu, Aug 28, 8:55 PM
F18380673: D18541.id44525.diff
Thu, Aug 28, 6:07 PM
F18380655: D18541.id44523.diff
Thu, Aug 28, 6:06 PM
F18380646: D18541.id.diff
Thu, Aug 28, 6:05 PM
F18380498: D18541.id44523.diff
Thu, Aug 28, 5:50 PM
F18380437: D18541.id44525.diff
Thu, Aug 28, 5:44 PM
View All Files
Subscribers
alexmv

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC92f7b2986cd7: (stable) Promote 2017 Week 36
rARCcbc785ddce71: Fix a similar lint rendering issue when trimming identical lines out of patches
Summary

Ref T9846. See PHI48. See D18538 for a similar fix. We can contract the suffix lines too much if, e.g, a newline after another newline is removed. Prevent contraction to fewer than 0 lines.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
11 lines
__tests__/
24 lines
data/
12 lines
6 lines

Diff 44525

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/remline.expect

Loading...
View Options

src/lint/renderer/__tests__/data/remline.txt

Loading...
Phabricator · Built by Phacility