Page MenuHomePhabricator

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
ClosedPublic

Authored by amckinley on Apr 24 2017, 11:13 PM.
Tags
None
Referenced Files
F15528122: D17787.id42771.diff
Tue, Apr 22, 9:10 AM
F15518945: D17787.id.diff
Sat, Apr 19, 6:21 PM
F15516313: D17787.diff
Fri, Apr 18, 5:59 PM
F15516176: D17787.id42771.diff
Fri, Apr 18, 4:58 PM
F15491562: D17787.diff
Sat, Apr 12, 4:56 AM
F15462829: D17787.id42778.diff
Tue, Apr 1, 5:57 PM
F15462354: D17787.id.diff
Tue, Apr 1, 2:22 PM
F15424540: D17787.diff
Mar 22 2025, 10:57 PM
Subscribers

Details

Summary

Fixes T12555.

Test Plan

Added this class to the codebase and ran arc liberate:

<?php

class FooBar {
    public static function doTheFoo() {
        return 'foobar';
    }
}

Ran arc lint and observed this warning:

Warning  (XHP87) Class Not `abstract` Or `final`
 This class is neither `final` nor `abstract`, and does not have a
 docblock marking it `@concrete-extensible`.

            1 <?php
            2
 >>>        3 class FooBar {
            4     public static function doTheFoo() {
            5         return "foobar";
            6     }

Added a final modifier to FooBar's declaration and observed the warning went away.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable