Page MenuHomePhabricator

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
ClosedPublic

Authored by amckinley on Apr 24 2017, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:39 PM
Unknown Object (File)
Mon, Apr 15, 12:24 PM
Unknown Object (File)
Mar 8 2024, 4:35 AM
Unknown Object (File)
Mar 4 2024, 5:27 AM
Unknown Object (File)
Jan 29 2024, 9:04 PM
Unknown Object (File)
Jan 8 2024, 2:20 PM
Unknown Object (File)
Dec 27 2023, 10:48 AM
Unknown Object (File)
Dec 27 2023, 10:48 AM
Subscribers

Details

Summary

Fixes T12555.

Test Plan

Added this class to the codebase and ran arc liberate:

<?php

class FooBar {
    public static function doTheFoo() {
        return 'foobar';
    }
}

Ran arc lint and observed this warning:

Warning  (XHP87) Class Not `abstract` Or `final`
 This class is neither `final` nor `abstract`, and does not have a
 docblock marking it `@concrete-extensible`.

            1 <?php
            2
 >>>        3 class FooBar {
            4     public static function doTheFoo() {
            5         return "foobar";
            6     }

Added a final modifier to FooBar's declaration and observed the warning went away.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable