Page MenuHomePhabricator

Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
ClosedPublic

Authored by amckinley on Apr 24 2017, 11:13 PM.
Tags
None
Referenced Files
F19228989: D17787.diff
Sat, Dec 20, 11:56 AM
F19201674: D17787.diff
Tue, Dec 16, 4:25 PM
F19061445: D17787.id42771.diff
Sat, Nov 29, 12:20 PM
F19059709: D17787.id42778.diff
Sat, Nov 29, 6:39 AM
F18906893: D17787.diff
Nov 8 2025, 8:56 PM
F18842919: D17787.diff
Oct 28 2025, 7:41 PM
F18589882: D17787.id.diff
Sep 12 2025, 4:34 AM
F18589313: D17787.id42778.diff
Sep 12 2025, 3:05 AM
Subscribers

Details

Summary

Fixes T12555.

Test Plan

Added this class to the codebase and ran arc liberate:

<?php

class FooBar {
    public static function doTheFoo() {
        return 'foobar';
    }
}

Ran arc lint and observed this warning:

Warning  (XHP87) Class Not `abstract` Or `final`
 This class is neither `final` nor `abstract`, and does not have a
 docblock marking it `@concrete-extensible`.

            1 <?php
            2
 >>>        3 class FooBar {
            4     public static function doTheFoo() {
            5         return "foobar";
            6     }

Added a final modifier to FooBar's declaration and observed the warning went away.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable