Page MenuHomePhabricator

Don't show a blank line if there is no user data
ClosedPublic

Authored by alexmv on Sep 20 2017, 9:35 PM.
Tags
None
Referenced Files
F15548361: D18632.id44732.diff
Sat, Apr 26, 11:14 PM
F15533069: D18632.id44732.diff
Wed, Apr 23, 6:12 PM
F15519329: D18632.diff
Sat, Apr 19, 9:48 PM
F15495123: D18632.id44736.diff
Sun, Apr 13, 2:51 AM
F15489330: D18632.id44732.diff
Fri, Apr 11, 7:58 AM
F15483949: D18632.id44735.diff
Wed, Apr 9, 3:26 PM
F15479524: D18632.id44736.diff
Tue, Apr 8, 7:51 AM
F15473016: D18632.id.diff
Apr 5 2025, 6:54 PM
Subscribers

Details

Summary

SKIP lines, for instance, often have no UserData; there is no
reason to display a content-less blank line.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Prefer a strlen() test over a plain test, so values like "0", "0.0", etc., are printed faithfully.

This revision now requires changes to proceed.Sep 20 2017, 9:43 PM

Swap to a strlen, instead of using truthiness

This revision is now accepted and ready to land.Sep 21 2017, 12:44 AM
This revision was automatically updated to reflect the committed changes.