Page MenuHomePhabricator

Don't show a blank line if there is no user data
ClosedPublic

Authored by alexmv on Sep 20 2017, 9:35 PM.

Details

Summary

SKIP lines, for instance, often have no UserData; there is no
reason to display a content-less blank line.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alexmv created this revision.Sep 20 2017, 9:35 PM
epriestley requested changes to this revision.Sep 20 2017, 9:43 PM

Prefer a strlen() test over a plain test, so values like "0", "0.0", etc., are printed faithfully.

This revision now requires changes to proceed.Sep 20 2017, 9:43 PM
alexmv updated this revision to Diff 44735.Sep 21 2017, 12:43 AM

Swap to a strlen, instead of using truthiness

epriestley accepted this revision.Sep 21 2017, 12:44 AM
This revision is now accepted and ready to land.Sep 21 2017, 12:44 AM
This revision was automatically updated to reflect the committed changes.