Paths

Table of Contentst

Don't show a blank line if there is no user data
ClosedPublic
Actions

Authored by alexmv on Sep 20 2017, 9:35 PM.

Tags

None

Referenced Files

	F15495123: D18632.id44736.diff
	Sun, Apr 13, 2:51 AM

	F15489330: D18632.id44732.diff
	Fri, Apr 11, 7:58 AM

	F15483949: D18632.id44735.diff
	Wed, Apr 9, 3:26 PM

	F15479524: D18632.id44736.diff
	Tue, Apr 8, 7:51 AM

	F15473016: D18632.id.diff
	Sat, Apr 5, 6:54 PM

	F15469877: D18632.diff
	Fri, Apr 4, 5:40 PM

	F15412648: D18632.diff
	Wed, Mar 19, 2:09 PM

	F15353335: D18632.id44736.diff
	Mar 10 2025, 9:17 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCe88a8c077b33: (stable) Promote 2017 Week 38
rARCc804c5026011: Don't show a blank line if there is no user data

Summary

SKIP lines, for instance, often have no UserData; there is no
reason to display a content-less blank line.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alexmv created this revision.Sep 20 2017, 9:35 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 20 2017, 9:35 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B18509: Diff 44732.Sep 20 2017, 9:35 PM

Prefer a strlen() test over a plain test, so values like "0", "0.0", etc., are printed faithfully.

This revision now requires changes to proceed.Sep 20 2017, 9:43 PM

Swap to a strlen, instead of using truthiness

Herald added a subscriber: Korvin. · View Herald TranscriptSep 21 2017, 12:44 AM

Harbormaster completed remote builds in B18513: Diff 44735.Sep 21 2017, 12:44 AM

epriestley accepted this revision.Sep 21 2017, 12:44 AM

This revision is now accepted and ready to land.Sep 21 2017, 12:44 AM

Closed by commit rARCc804c5026011: Don't show a blank line if there is no user data (authored by alexmv). · Explain WhySep 21 2017, 12:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

unit/

renderer/

ArcanistUnitConsoleRenderer.php

3 lines

Diff 44736

View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

Don't show a blank line if there is no user dataClosedPublicActions