HomePhabricator

Improve the flake8 line-matching regex

Authored by jparise on Mar 24 2017, 3:26 PM.

Description

Improve the flake8 line-matching regex

Summary:
Because the character offset group is optional, the logic for dealing
with the previous index-based match object was more complex than it
needs to be. Switching to named groups makes this clearer.

As an example of how this was causing a problem, when the character
group *was* present (at index 3), it was being appending to the linter's
name in the call to ->setName(), resulting in confusing linter output.
We may have also been setting the character offset to the error code's
string, too, which is further nonsense.

Because we reliably capture the flake8 error code, I don't think there's
a need to append it to the linter's name at all now, so I removed that
part (so it's always just flake8), but it's not a problem to restore.

Lastly, I hoisted $regex out of the loop because it's a constant and
de-indenting it gave me enough room to continuing writing it all on one
line.

Test Plan: Tested primarily with flake8 3.3.0

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17552

Details

Committed
jpariseMar 24 2017, 4:19 PM
Pushed
jpariseMar 24 2017, 4:19 PM
Reviewer
Blessed Reviewers
Differential Revision
D17552: Improve the flake8 line-matching regex
Parents
rARC3b6b523c2b23: Fix errors found by PHPStan
Branches
Unknown
Tags
Unknown
Build Status
Buildable 16132
Build 21410: Run Core Tests