Page MenuHomePhabricator

Fix a property name collision in ArcanistHgServerChannel
ClosedPublic

Authored by epriestley on Feb 16 2017, 1:11 PM.
Tags
None
Referenced Files
F19031791: D17366.diff
Tue, Nov 25, 2:44 AM
F18843395: D17366.id.diff
Oct 28 2025, 9:50 PM
F18839460: D17366.diff
Oct 27 2025, 4:36 PM
F18702244: D17366.id41763.diff
Sep 27 2025, 11:23 PM
F18701810: D17366.id.diff
Sep 27 2025, 9:10 PM
F18688437: D17366.diff
Sep 26 2025, 4:29 PM
F18658994: D17366.id41760.diff
Sep 23 2025, 9:22 AM
F18658093: D17366.diff
Sep 23 2025, 4:48 AM
Subscribers
None

Details

Summary

See D2665. Here, channel is the Mercurial wire protocol channel name ("o" = "output", "e" = "error", etc), not the underlying channel from PhutilProxyChannel.

Rename the property so there's no collision.

Test Plan
$ ../../core/lib/arcanist/scripts/hgdaemon/hgdaemon_client.php . --trace --skip-hello
array(3) {
  [0]=>
  int(0)
  [1]=>
  string(103) "capabilities: getencoding runcommand
encoding: UTF-8
pid: 73263e20cf21273d50f1f66cab6e0f7c74f4864e67f0f"
  [2]=>
  string(0) ""
}

Executed in 30647 us.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 16 2017, 1:18 PM
This revision was automatically updated to reflect the committed changes.