Fix a property name collision in ArcanistHgServerChannel
ClosedPublic
Actions

Authored by epriestley on Feb 16 2017, 1:11 PM.

Tags

None

Referenced Files

	F18092214: D17366.id41763.diff
	Thu, Aug 7, 8:21 AM

	F18091519: D17366.id.diff
	Wed, Aug 6, 10:20 PM

	F18084889: D17366.diff
	Tue, Aug 5, 6:26 PM

	F17705746: D17366.id41763.diff
	Jul 16 2025, 9:02 AM

	Unknown Object (File)
	Jun 28 2025, 10:00 PM

	Unknown Object (File)
	Jun 27 2025, 10:20 PM

	Unknown Object (File)
	Jun 27 2025, 7:39 AM

	Unknown Object (File)
	Jun 26 2025, 5:17 PM

View All Files

Subscribers

None

Details

Reviewers

vrana
chad

Commits

rARC460b0e46eea0: Fix a property name collision in ArcanistHgServerChannel

Summary

See D2665. Here, channel is the Mercurial wire protocol channel name ("o" = "output", "e" = "error", etc), not the underlying channel from PhutilProxyChannel.

Rename the property so there's no collision.

Test Plan

$ ../../core/lib/arcanist/scripts/hgdaemon/hgdaemon_client.php . --trace --skip-hello
array(3) {
  [0]=>
  int(0)
  [1]=>
  string(103) "capabilities: getencoding runcommand
encoding: UTF-8
pid: 73263e20cf21273d50f1f66cab6e0f7c74f4864e67f0f"
  [2]=>
  string(0) ""
}

Executed in 30647 us.