Fix a property name collision in ArcanistHgServerChannel
ClosedPublic
Actions

Authored by epriestley on Feb 16 2017, 1:11 PM.

Tags

None

Referenced Files

	F15451718: D17366.id41760.diff
	Fri, Mar 28, 11:32 PM

	F15449712: D17366.id41763.diff
	Fri, Mar 28, 11:48 AM

	F15448938: D17366.id41763.diff
	Fri, Mar 28, 7:47 AM

	F15447362: D17366.id.diff
	Thu, Mar 27, 11:20 PM

	F15442680: D17366.diff
	Wed, Mar 26, 11:58 PM

	F15441502: D17366.diff
	Wed, Mar 26, 6:32 PM

	F15437137: D17366.diff
	Tue, Mar 25, 5:49 PM

	F15418400: D17366.id41760.diff
	Thu, Mar 20, 11:06 PM

View All Files

Subscribers

None

Details

Reviewers

vrana
chad

Commits

rARC460b0e46eea0: Fix a property name collision in ArcanistHgServerChannel

Summary

See D2665. Here, channel is the Mercurial wire protocol channel name ("o" = "output", "e" = "error", etc), not the underlying channel from PhutilProxyChannel.

Rename the property so there's no collision.

Test Plan

$ ../../core/lib/arcanist/scripts/hgdaemon/hgdaemon_client.php . --trace --skip-hello
array(3) {
  [0]=>
  int(0)
  [1]=>
  string(103) "capabilities: getencoding runcommand
encoding: UTF-8
pid: 73263e20cf21273d50f1f66cab6e0f7c74f4864e67f0f"
  [2]=>
  string(0) ""
}

Executed in 30647 us.