Fix a property name collision in ArcanistHgServerChannel
ClosedPublic

Authored by epriestley on Thu, Feb 16, 1:11 PM.

Details

Summary

See D2665. Here, channel is the Mercurial wire protocol channel name ("o" = "output", "e" = "error", etc), not the underlying channel from PhutilProxyChannel.

Rename the property so there's no collision.

Test Plan
$ ../../core/lib/arcanist/scripts/hgdaemon/hgdaemon_client.php . --trace --skip-hello
array(3) {
  [0]=>
  int(0)
  [1]=>
  string(103) "capabilities: getencoding runcommand
encoding: UTF-8
pid: 73263e20cf21273d50f1f66cab6e0f7c74f4864e67f0f"
  [2]=>
  string(0) ""
}

Executed in 30647 us.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Thu, Feb 16, 1:11 PM
vrana accepted this revision.Thu, Feb 16, 1:18 PM
This revision is now accepted and ready to land.Thu, Feb 16, 1:18 PM
This revision was automatically updated to reflect the committed changes.