Page MenuHomePhabricator
Feed All Stories

May 23 2020

avivey awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Manufacturing Defect? token.
May 23 2020, 6:19 AM · Differential, Quick Look
mcorteel awarded Blog Post: Quick Look: Inline Comments on Character Ranges a Love token.
May 23 2020, 5:47 AM · Quick Look, Differential
hskiba awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Mountain of Wealth token.
May 23 2020, 2:04 AM · Differential, Quick Look

May 22 2020

epriestley committed rP4042ea648518: (stable) When cancelling an edit of an inline with content, don't hide the… (authored by epriestley).
(stable) When cancelling an edit of an inline with content, don't hide the…
May 22 2020, 10:41 PM
epriestley committed rP3635a11f848f: When cancelling an edit of an inline with content, don't hide the inline (authored by epriestley).
When cancelling an edit of an inline with content, don't hide the inline
May 22 2020, 10:40 PM
epriestley closed D21286: When cancelling an edit of an inline with content, don't hide the inline.
May 22 2020, 10:40 PM
epriestley requested review of D21286: When cancelling an edit of an inline with content, don't hide the inline.
May 22 2020, 10:30 PM
cspeckmim awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
May 22 2020, 9:53 PM · Differential, Quick Look
epriestley edited the content of Changelog.
May 22 2020, 9:44 PM
epriestley created an object: 2020 Week 20 (Late May).
May 22 2020, 9:43 PM
epriestley created Blog Post: Quick Look: Suggesting Edits with Inline Comments.
May 22 2020, 9:41 PM · Differential, Quick Look
epriestley committed rP73024e454239: (stable) Promote 2020 Week 20 (authored by epriestley).
(stable) Promote 2020 Week 20
May 22 2020, 9:23 PM
epriestley committed rP959a835b95dd: When executing a repository passthru command via CommandEngine, don't set a… (authored by epriestley).
When executing a repository passthru command via CommandEngine, don't set a…
May 22 2020, 6:54 PM
epriestley closed D21284: When executing a repository passthru command via CommandEngine, don't set a timeout.
May 22 2020, 6:54 PM
epriestley committed rP828798f3e1b4: (stable) Fix two rendering issues with Jupyter notebooks (authored by epriestley).
(stable) Fix two rendering issues with Jupyter notebooks
May 22 2020, 6:54 PM
epriestley committed rP4fd0628fae45: Fix two rendering issues with Jupyter notebooks (authored by epriestley).
Fix two rendering issues with Jupyter notebooks
May 22 2020, 6:54 PM
epriestley closed D21285: Fix two rendering issues with Jupyter notebooks.
May 22 2020, 6:54 PM
epriestley requested review of D21285: Fix two rendering issues with Jupyter notebooks.
May 22 2020, 6:52 PM
sshannin added a comment to T7469: Handle folder copies/moves more gracefully.

(there's usually no value in reviewing individual file-level changes in a "create a new branch X" commit)

Completely agree that there's no value in reviewing those individually. But to be clear, my point in making this ticket was mostly that you can't discern from the browser that this was a "create a new branch" commit. Right now it just renders the whole file tree saying showing 3000 files individually copied instead of a simpler/single line saying the whole directory was copied.

May 22 2020, 6:10 PM · Diffusion, Subversion
epriestley requested review of D21284: When executing a repository passthru command via CommandEngine, don't set a timeout.
May 22 2020, 12:46 PM
epriestley added a revision to T13541: Very large repositories may fail initial fetches after 15 minutes: D21284: When executing a repository passthru command via CommandEngine, don't set a timeout.
May 22 2020, 12:45 PM · Diffusion
epriestley triaged T13541: Very large repositories may fail initial fetches after 15 minutes as Low priority.
May 22 2020, 12:02 PM · Diffusion
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

Since many of these options probably don't have "right answers", I'm trying this reasonable-seeming variation on some repositories which seem like they'll benefit from a repack:

May 22 2020, 3:03 AM · Phacility, Diffusion

May 21 2020

epriestley committed rP87fb35abb72e: Prevent keyboard selection of change blocks inside edit suggestions (authored by epriestley).
Prevent keyboard selection of change blocks inside edit suggestions
May 21 2020, 10:38 PM
epriestley closed D21283: Prevent keyboard selection of change blocks inside edit suggestions.
May 21 2020, 10:37 PM
epriestley committed rP66566f878d82: Make "Open in Editor" use the simple line number of the current selected block (authored by epriestley).
Make "Open in Editor" use the simple line number of the current selected block
May 21 2020, 10:31 PM
epriestley closed D21282: Make "Open in Editor" use the simple line number of the current selected block.
May 21 2020, 10:31 PM
epriestley updated the summary of D21283: Prevent keyboard selection of change blocks inside edit suggestions.
May 21 2020, 10:10 PM
epriestley requested review of D21283: Prevent keyboard selection of change blocks inside edit suggestions.
May 21 2020, 10:07 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21283: Prevent keyboard selection of change blocks inside edit suggestions.
May 21 2020, 10:06 PM · Inline Comments, Diffusion, Differential
epriestley updated the diff for D21282: Make "Open in Editor" use the simple line number of the current selected block.
  • Ignore selected elements that are not part of the current changeset.
May 21 2020, 9:44 PM
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • j, etc., can incorrectly select blocks inside a diff inside a suggestion.
May 21 2020, 9:41 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21282: Make "Open in Editor" use the simple line number of the current selected block.
May 21 2020, 9:32 PM
epriestley triaged T13540: "Dark Mode" UI issues as Wishlist priority.
May 21 2020, 8:32 PM · Design
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

See PHI1748. I ran a query against a subset of instances to determine how widespread usage of "Dark Mode" is, to help inform a decision to either implement the mode properly (see T12311) or remove the mode. The query was of this form:

May 21 2020, 8:08 PM · Phacility
epriestley closed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) as Resolved.

I think (?) this was pretty much resolved by the last round of changes. See T13291 for some followups.

May 21 2020, 4:03 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley closed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does), a subtask of T13285: Service failures in JIRA can cascade into service failures in Phabricator, as Resolved.
May 21 2020, 4:03 PM · Doorkeeper

May 20 2020

epriestley committed rPd3d41324be9f: Drop old "differential_commit" table (authored by epriestley).
Drop old "differential_commit" table
May 20 2020, 9:30 PM
epriestley closed D21281: Drop old "differential_commit" table.
May 20 2020, 9:30 PM
epriestley committed rP6d0dbeb77f77: Use the changeset parse cache to cache suggestion changesets (authored by epriestley).
Use the changeset parse cache to cache suggestion changesets
May 20 2020, 9:29 PM
epriestley closed D21280: Use the changeset parse cache to cache suggestion changesets.
May 20 2020, 9:29 PM
epriestley committed rP5d0ae283a9ab: Put a readthrough cache in front of inline context construction (authored by epriestley).
Put a readthrough cache in front of inline context construction
May 20 2020, 9:28 PM
epriestley closed D21279: Put a readthrough cache in front of inline context construction.
May 20 2020, 9:28 PM
epriestley committed rPd2d7e7f5ff1b: Clean up Diffusion behaviors for inline edit suggestions (authored by epriestley).
Clean up Diffusion behaviors for inline edit suggestions
May 20 2020, 9:28 PM
epriestley closed D21278: Clean up Diffusion behaviors for inline edit suggestions.
May 20 2020, 9:28 PM
epriestley committed rP10f241352dce: Render inline comment suggestions as real diffs (authored by epriestley).
Render inline comment suggestions as real diffs
May 20 2020, 9:27 PM
epriestley closed D21277: Render inline comment suggestions as real diffs.
May 20 2020, 9:27 PM
epriestley committed rP846562158aae: Roughly support inline comment suggestions (authored by epriestley).
Roughly support inline comment suggestions
May 20 2020, 9:26 PM
epriestley closed D21276: Roughly support inline comment suggestions.
May 20 2020, 9:26 PM
epriestley committed rP00430fdbe117: Make server components of inline comment content handling state-oriented (authored by epriestley).
Make server components of inline comment content handling state-oriented
May 20 2020, 9:26 PM
epriestley closed D21275: Make server components of inline comment content handling state-oriented.
May 20 2020, 9:26 PM
epriestley committed rP4b2a447003be: Allow "has draft inlines?" queries to overheat (authored by epriestley).
Allow "has draft inlines?" queries to overheat
May 20 2020, 9:25 PM
epriestley closed D21274: Allow "has draft inlines?" queries to overheat.
May 20 2020, 9:25 PM
epriestley committed rP87bc30526b7a: Make inline content "state-oriented", not "string-oriented" (authored by epriestley).
Make inline content "state-oriented", not "string-oriented"
May 20 2020, 9:24 PM
epriestley closed D21273: Make inline content "state-oriented", not "string-oriented".
May 20 2020, 9:24 PM
epriestley requested review of D21281: Drop old "differential_commit" table.
May 20 2020, 7:31 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D21281: Drop old "differential_commit" table.
May 20 2020, 7:30 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21281: Drop old "differential_commit" table.
May 20 2020, 7:30 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21280: Use the changeset parse cache to cache suggestion changesets.
May 20 2020, 6:38 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21280: Use the changeset parse cache to cache suggestion changesets.
May 20 2020, 6:37 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

I made a change to drop unchanged context from suggestion views, but I don't particularly like it. It changed this:

May 20 2020, 6:31 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21279: Put a readthrough cache in front of inline context construction.
May 20 2020, 5:38 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21279: Put a readthrough cache in front of inline context construction.
May 20 2020, 5:37 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21278: Clean up Diffusion behaviors for inline edit suggestions.
May 20 2020, 4:23 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21278: Clean up Diffusion behaviors for inline edit suggestions.
May 20 2020, 4:22 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21277: Render inline comment suggestions as real diffs.
May 20 2020, 4:12 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21277: Render inline comment suggestions as real diffs.
May 20 2020, 4:10 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • Inline comments with suggestions don't "know" that they're empty when the suggestion is the same as the context text.
    • Create an inline. Suggest edit. Don't change anything. Save. You get a blank inline with no suggestion and no content, when this inline would normally delete itself.
May 20 2020, 3:53 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

The inline comment context menu does not apply the correct cursor ("pointer").

May 20 2020, 3:23 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21276: Roughly support inline comment suggestions.
May 20 2020, 3:17 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21276: Roughly support inline comment suggestions.
May 20 2020, 3:16 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

I still have a lot of inline style attributes to clean up and then I'm sure there will be a long tail of weird edge cases, but this is getting pretty close:

May 20 2020, 12:31 AM · Inline Comments, Diffusion, Differential

May 19 2020

epriestley requested review of D21275: Make server components of inline comment content handling state-oriented.
May 19 2020, 9:57 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21275: Make server components of inline comment content handling state-oriented.
May 19 2020, 9:56 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • This isn't necessarily terribly useful in practice, but a UI hint about whether or not we've actually saved a draft would make debugging slightly easier.
May 19 2020, 9:53 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21274: Allow "has draft inlines?" queries to overheat.
May 19 2020, 8:55 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21274: Allow "has draft inlines?" queries to overheat.
May 19 2020, 8:54 PM · Inline Comments, Diffusion, Differential
epriestley requested review of D21273: Make inline content "state-oriented", not "string-oriented".
May 19 2020, 8:52 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21273: Make inline content "state-oriented", not "string-oriented".
May 19 2020, 8:51 PM · Inline Comments, Diffusion, Differential
epriestley committed rP9d5b8bd14a97: Remove PHPMailer code which generates bogus "Message-ID" email headers (authored by epriestley).
Remove PHPMailer code which generates bogus "Message-ID" email headers
May 19 2020, 6:39 PM
epriestley closed D21272: Remove PHPMailer code which generates bogus "Message-ID" email headers.
May 19 2020, 6:39 PM
epriestley requested review of D21272: Remove PHPMailer code which generates bogus "Message-ID" email headers.
May 19 2020, 6:19 PM
epriestley committed rP1aa0569b6086: (stable) Treat PHP7 "Throwable" exceptions like other unhandled "Exception"… (authored by epriestley).
(stable) Treat PHP7 "Throwable" exceptions like other unhandled "Exception"…
May 19 2020, 5:42 PM
epriestley updated the summary of D21271: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue.
May 19 2020, 5:42 PM
epriestley committed rP4257b26abc61: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the… (authored by epriestley).
Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the…
May 19 2020, 5:41 PM
epriestley closed D21271: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue.
May 19 2020, 5:41 PM
epriestley committed rP400c555666c5: (stable) Update out-of-date API calls when rendering diffs inline in email (authored by epriestley).
(stable) Update out-of-date API calls when rendering diffs inline in email
May 19 2020, 5:41 PM
epriestley requested review of D21271: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue.
May 19 2020, 5:41 PM
epriestley committed rP43a8d8763df3: Update out-of-date API calls when rendering diffs inline in email (authored by epriestley).
Update out-of-date API calls when rendering diffs inline in email
May 19 2020, 5:40 PM
epriestley closed D21270: Update out-of-date API calls when rendering diffs inline in email.
May 19 2020, 5:40 PM
epriestley requested review of D21270: Update out-of-date API calls when rendering diffs inline in email.
May 19 2020, 5:32 PM
epriestley added a comment to T13538: Git commits with no commit message fail to import/parse.

Remaining work here is:

May 19 2020, 4:48 PM · Diffusion
epriestley committed rP4fd7c0f7b3ca: (stable) Fix an issue where builds with no initiator failed to render in build… (authored by epriestley).
(stable) Fix an issue where builds with no initiator failed to render in build…
May 19 2020, 4:46 PM
epriestley committed rP86d6abe9db26: Fix an issue where builds with no initiator failed to render in build plans (authored by epriestley).
Fix an issue where builds with no initiator failed to render in build plans
May 19 2020, 4:46 PM
epriestley closed D21269: Fix an issue where builds with no initiator failed to render in build plans.
May 19 2020, 4:46 PM
epriestley requested review of D21269: Fix an issue where builds with no initiator failed to render in build plans.
May 19 2020, 4:46 PM
epriestley committed rP8dec499bcf0a: (stable) Fix "r" and "R" both replying with quote on inline comments (authored by epriestley).
(stable) Fix "r" and "R" both replying with quote on inline comments
May 19 2020, 4:29 PM
epriestley committed rP770a5c8412d1: Fix "r" and "R" both replying with quote on inline comments (authored by epriestley).
Fix "r" and "R" both replying with quote on inline comments
May 19 2020, 4:28 PM
epriestley closed D21268: Fix "r" and "R" both replying with quote on inline comments.
May 19 2020, 4:28 PM
epriestley requested review of D21268: Fix "r" and "R" both replying with quote on inline comments.
May 19 2020, 4:28 PM