- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 23 2020
May 22 2020
(there's usually no value in reviewing individual file-level changes in a "create a new branch X" commit)
Completely agree that there's no value in reviewing those individually. But to be clear, my point in making this ticket was mostly that you can't discern from the browser that this was a "create a new branch" commit. Right now it just renders the whole file tree saying showing 3000 files individually copied instead of a simpler/single line saying the whole directory was copied.
Since many of these options probably don't have "right answers", I'm trying this reasonable-seeming variation on some repositories which seem like they'll benefit from a repack:
May 21 2020
- Ignore selected elements that are not part of the current changeset.
- j, etc., can incorrectly select blocks inside a diff inside a suggestion.
I think (?) this was pretty much resolved by the last round of changes. See T13291 for some followups.
May 20 2020
I made a change to drop unchanged context from suggestion views, but I don't particularly like it. It changed this:
- Inline comments with suggestions don't "know" that they're empty when the suggestion is the same as the context text.
- Create an inline. Suggest edit. Don't change anything. Save. You get a blank inline with no suggestion and no content, when this inline would normally delete itself.
The inline comment context menu does not apply the correct cursor ("pointer").
I still have a lot of inline style attributes to clean up and then I'm sure there will be a long tail of weird edge cases, but this is getting pretty close:
May 19 2020
- This isn't necessarily terribly useful in practice, but a UI hint about whether or not we've actually saved a draft would make debugging slightly easier.
Remaining work here is: