Page MenuHomePhabricator

When executing a repository passthru command via CommandEngine, don't set a timeout
ClosedPublic

Authored by epriestley on May 22 2020, 12:45 PM.

Details

Summary

Ref T13541. The passthru future does not have time limit behavior, so if we reach this code we currently fail.

Phabricator never reaches this code normally, but this code is reachable during debugging if you try to foreground a slow fetch to inspect it.

Passthru commands generally only make sense to run interactively, and the caller or control script can enforce their own timeouts (usually by pressing "^C" with their fingers).

Test Plan

Used a debugging script to run ref-by-ref fetches in the foreground.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2020, 6:54 PM
This revision was automatically updated to reflect the committed changes.