Page MenuHomePhabricator

Allow "has draft inlines?" queries to overheat
ClosedPublic

Authored by epriestley on May 19 2020, 8:54 PM.
Tags
None
Referenced Files
F14092152: D21274.diff
Mon, Nov 25, 4:22 AM
Unknown Object (File)
Sun, Nov 24, 12:57 AM
Unknown Object (File)
Thu, Nov 21, 12:11 AM
Unknown Object (File)
Sun, Nov 17, 8:23 AM
Unknown Object (File)
Sat, Nov 9, 4:17 PM
Unknown Object (File)
Oct 15 2024, 1:21 AM
Unknown Object (File)
Sep 21 2024, 9:00 AM
Unknown Object (File)
Sep 7 2024, 11:45 PM
Subscribers
None

Details

Summary

Ref T13513. If your 10 most recently authored inlines have all been deleted, these queries can fail by overheating. This is silly and probably rarely happens outside of development.

For now, just let them overheat. This may create a false negative (incorrect "no draft" signal when the real condition is "drafts, but 10 most recent comments were deleted"). This could be sorted out later with a query mode like "executeAny()", perhaps.

Test Plan
  • Created and deleted 10 inlines.
  • Submitted comments.
  • Before: overheating fatal during draft flag generation.
  • After: clean submission.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:25 PM
This revision was automatically updated to reflect the committed changes.