Page MenuHomePhabricator

Allow "has draft inlines?" queries to overheat
ClosedPublic

Authored by epriestley on Tue, May 19, 8:54 PM.

Details

Summary

Ref T13513. If your 10 most recently authored inlines have all been deleted, these queries can fail by overheating. This is silly and probably rarely happens outside of development.

For now, just let them overheat. This may create a false negative (incorrect "no draft" signal when the real condition is "drafts, but 10 most recent comments were deleted"). This could be sorted out later with a query mode like "executeAny()", perhaps.

Test Plan
  • Created and deleted 10 inlines.
  • Submitted comments.
  • Before: overheating fatal during draft flag generation.
  • After: clean submission.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, May 19, 8:54 PM
epriestley requested review of this revision.Tue, May 19, 8:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, May 20, 9:25 PM
This revision was automatically updated to reflect the committed changes.