Paths

Table of Contentst

Differential D21269

Fix an issue where builds with no initiator failed to render in build plans
ClosedPublic
Actions

Authored by epriestley on May 19 2020, 4:44 PM.

Tags

None

Referenced Files

	F15193722: D21269.diff
	Sat, Feb 22, 6:32 AM

	F15193162: D21269.id50648.diff
	Sat, Feb 22, 4:13 AM

	Unknown Object (File)
	Sat, Feb 1, 12:40 PM

	Unknown Object (File)
	Tue, Jan 28, 10:24 AM

	Unknown Object (File)
	Jan 23 2025, 7:35 AM

	Unknown Object (File)
	Jan 21 2025, 11:20 AM

	Unknown Object (File)
	Jan 19 2025, 2:48 AM

	Unknown Object (File)
	Jan 8 2025, 2:32 PM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Commits: rP4fd7c0f7b3ca: (stable) Fix an issue where builds with no initiator failed to render in build…
rP86d6abe9db26: Fix an issue where builds with no initiator failed to render in build plans

Summary

See PHI1743. If a build has no initiator PHID, the rendering pathway incorrectly tries to access a handle for it anyway.

Test Plan

Set a build to have no initiator PHID.
Viewed the build plan for the build.
Before: fatal when trying to access the null handle.
After: clean build plan rendering.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 19 2020, 4:44 PM

Owners added a subscriber: Restricted Owners Package.May 19 2020, 4:44 PM

Harbormaster completed remote builds in B24466: Diff 50647.May 19 2020, 4:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2020, 4:46 PM

epriestley requested review of this revision.

Closed by commit rP86d6abe9db26: Fix an issue where builds with no initiator failed to render in build plans (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP86d6abe9db26: Fix an issue where builds with no initiator failed to render in build plans.

epriestley added a commit: rP4fd7c0f7b3ca: (stable) Fix an issue where builds with no initiator failed to render in build….

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

view/

HarbormasterBuildView.php

6 lines

Diff 50648

src/applications/harbormaster/view/HarbormasterBuildView.php

Loading...