Page MenuHomePhabricator

Fix an issue where builds with no initiator failed to render in build plans
ClosedPublic

Authored by epriestley on Tue, May 19, 4:44 PM.

Details

Summary

See PHI1743. If a build has no initiator PHID, the rendering pathway incorrectly tries to access a handle for it anyway.

Test Plan
  • Set a build to have no initiator PHID.
  • Viewed the build plan for the build.
  • Before: fatal when trying to access the null handle.
  • After: clean build plan rendering.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, May 19, 4:44 PM
Owners added a subscriber: Restricted Owners Package.Tue, May 19, 4:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 19, 4:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.