Page MenuHomePhabricator

Put a readthrough cache in front of inline context construction
ClosedPublic

Authored by epriestley on Wed, May 20, 5:37 PM.

Details

Summary

Ref T13513. Inline comment context information is somewhat expensive to construct and can be cached. Add a readthrough cache on top of it.

Test Plan

Loaded a source code changeset with many inline comments, used Darkconsole to inspect query activity. Saw caches get populated. Updated cache key, saw caches regenerate. Browsed Diffusion, nothing looked broken.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, May 20, 5:37 PM
epriestley requested review of this revision.Wed, May 20, 5:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, May 20, 9:28 PM
This revision was automatically updated to reflect the committed changes.