Diffusion Phabricator 3635a11f848f

When cancelling an edit of an inline with content, don't hide the inline
3635a11f848f
Actions

Description

When cancelling an edit of an inline with content, don't hide the inline

Summary: See PHI1753. This condition got rewritten for suggested edits and accidentally inverted.

Test Plan:

Create a comment, type text, save draft, edit comment, cancel.
Before: comment hides itself.
After: comment properly cancels into pre-edit draft state.

Differential Revision: https://secure.phabricator.com/D21286

Details

Provenance

epriestley	Authored on May 22 2020, 10:27 PM
epriestley	Pushed on May 22 2020, 10:40 PM

Differential Revision

D21286: When cancelling an edit of an inline with content, don't hide the inline

Parents

rP959a835b95dd: When executing a repository passthru command via CommandEngine, don't set a…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 24508
Build 33774: Run Core Tests

Event Timeline

epriestley committed rP3635a11f848f: When cancelling an edit of an inline with content, don't hide the inline (authored by epriestley).May 22 2020, 10:40 PM

epriestley added an edge: D21286: When cancelling an edit of an inline with content, don't hide the inline.

Harbormaster completed building B24508: rP3635a11f848f: When cancelling an edit of an inline with content, don't hide the inline.May 22 2020, 10:41 PM

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

rP3635a11f848f

View Options

resources/celerity/map.php