Page MenuHomePhabricator

Prevent keyboard selection of change blocks inside edit suggestions
ClosedPublic

Authored by epriestley on May 21 2020, 10:06 PM.

Details

Summary

Ref T13513. When a revision has inlines with edit suggestions, pressing "j" and "k" can incorrectly select the blocks inside the diffs inside the inlines.

Test Plan

Used "j" to cycle through changes in a revision with inline comments with edit suggestions, didn't get jumped into the suggestion diffs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 21 2020, 10:37 PM
This revision was automatically updated to reflect the committed changes.