Page MenuHomePhabricator

Prevent keyboard selection of change blocks inside edit suggestions
ClosedPublic

Authored by epriestley on Thu, May 21, 10:06 PM.

Details

Summary

Ref T13513. When a revision has inlines with edit suggestions, pressing "j" and "k" can incorrectly select the blocks inside the diffs inside the inlines.

Test Plan

Used "j" to cycle through changes in a revision with inline comments with edit suggestions, didn't get jumped into the suggestion diffs.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 21, 10:06 PM
epriestley requested review of this revision.Thu, May 21, 10:07 PM
epriestley edited the summary of this revision. (Show Details)Thu, May 21, 10:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 21, 10:37 PM
This revision was automatically updated to reflect the committed changes.