Prevent keyboard selection of change blocks inside edit suggestions
ClosedPublic
Actions

Authored by epriestley on May 21 2020, 10:06 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP87fb35abb72e: Prevent keyboard selection of change blocks inside edit suggestions

Summary

Ref T13513. When a revision has inlines with edit suggestions, pressing "j" and "k" can incorrectly select the blocks inside the diffs inside the inlines.

Test Plan

Used "j" to cycle through changes in a revision with inline comments with edit suggestions, didn't get jumped into the suggestion diffs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 21 2020, 10:06 PM

Harbormaster completed remote builds in B24498: Diff 50679.May 21 2020, 10:07 PM

epriestley requested review of this revision.May 21 2020, 10:07 PM

epriestley edited the summary of this revision. (Show Details)May 21 2020, 10:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 21 2020, 10:37 PM

Closed by commit rP87fb35abb72e: Prevent keyboard selection of change blocks inside edit suggestions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP87fb35abb72e: Prevent keyboard selection of change blocks inside edit suggestions.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangeset.js

15 lines

Diff 50681

View Options

resources/celerity/map.php