Page MenuHomePhabricator

Use the changeset parse cache to cache suggestion changesets
ClosedPublic

Authored by epriestley on Wed, May 20, 6:37 PM.

Details

Summary

Ref T13513. Syntax highlighting is potentially expensive, and the changeset rendering pipeline can cache it. However, the cache is currently keyed ONLY by Differential changeset ID.

Destroy the existing cache and rebuild it with a more standard cache key so it can be used in a more ad-hoc way by inline suggestion snippets.

Test Plan

Used Darkconsole, saw cache hits and no more inline syntax highlighting for changesets with many inlines.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, May 20, 6:37 PM
Owners added a subscriber: Restricted Owners Package.Wed, May 20, 6:37 PM
epriestley requested review of this revision.Wed, May 20, 6:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, May 20, 9:29 PM
This revision was automatically updated to reflect the committed changes.