Page MenuHomePhabricator

Make inline content "state-oriented", not "string-oriented"
ClosedPublic

Authored by epriestley on May 19 2020, 8:51 PM.
Tags
None
Referenced Files
F15402788: D21273.id50658.diff
Tue, Mar 18, 12:22 AM
F15366172: D21273.diff
Tue, Mar 11, 2:33 PM
F15316215: D21273.diff
Thu, Mar 6, 6:26 PM
Unknown Object (File)
Mon, Feb 24, 2:45 AM
Unknown Object (File)
Sat, Feb 22, 10:32 AM
Unknown Object (File)
Fri, Feb 21, 8:12 PM
Unknown Object (File)
Feb 18 2025, 4:27 AM
Unknown Object (File)
Feb 14 2025, 5:35 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, all the inline code passes around strings to describe content. I plan to add background music, animation effects, etc., soon. To prepare for this change, make content a state object.

This does not change any user-visible behavior, it just prepares for content to become more complicated than a single string.

Test Plan

Created, edited, submitted, cancelled, etc., comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:24 PM
This revision was automatically updated to reflect the committed changes.