Page MenuHomePhabricator

Make inline content "state-oriented", not "string-oriented"
ClosedPublic

Authored by epriestley on Tue, May 19, 8:51 PM.

Details

Summary

Ref T13513. Currently, all the inline code passes around strings to describe content. I plan to add background music, animation effects, etc., soon. To prepare for this change, make content a state object.

This does not change any user-visible behavior, it just prepares for content to become more complicated than a single string.

Test Plan

Created, edited, submitted, cancelled, etc., comments.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, May 19, 8:51 PM
epriestley requested review of this revision.Tue, May 19, 8:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, May 20, 9:24 PM
This revision was automatically updated to reflect the committed changes.