Page MenuHomePhabricator

Clean up Diffusion behaviors for inline edit suggestions
ClosedPublic

Authored by epriestley on Wed, May 20, 4:22 PM.

Details

Summary

Ref T13513. For now, I'm not supporting inline edit suggestions in Diffusion, although it's likely not difficult to do so in the future. Clean up some of the code so that plain ol' inlines work the same way they did before.

Test Plan
  • Created, edited, reloaded, submitted inlines in Diffusion: familiar old behavior.
  • Created, edited, reloaded, submitted inlines with suggestions in Differential: familiar new behavior.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, May 20, 4:22 PM
epriestley requested review of this revision.Wed, May 20, 4:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, May 20, 9:28 PM
This revision was automatically updated to reflect the committed changes.