Page MenuHomePhabricator

Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue

Authored by epriestley on Tue, May 19, 5:39 PM.



See PHI1745. See T12855. Under PHP7, errors raised as Throwable miss this "generic exception" logic and don't increment their failure count. Instead, treat any "Throwable" we don't recognize like any "Exception" we don't recognize.

Test Plan
  • Under PHP7, caused a worker task to raise a Throwable (e.g., call to undefined method, see D21270).
  • Ran bin/worker execute --id ....
  • Before: worker failed, but did not increment failure count.
  • After: worker fails and increments failure count as it would for other types of unknown error.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, May 19, 5:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 19, 5:41 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.
epriestley edited the summary of this revision. (Show Details)Tue, May 19, 5:42 PM